Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-16269: Update reassign_partitions_test.py to support KIP-848’s group protocol config #15540

Merged
merged 1 commit into from
Mar 15, 2024
Merged

KAFKA-16269: Update reassign_partitions_test.py to support KIP-848’s group protocol config #15540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 7 additions & 5 deletions tests/kafkatest/tests/core/reassign_partitions_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

from kafkatest.services.kafka import config_property
from kafkatest.services.zookeeper import ZookeeperService
from kafkatest.services.kafka import KafkaService, quorum
from kafkatest.services.kafka import KafkaService, quorum, consumer_group
from kafkatest.services.verifiable_producer import VerifiableProducer
from kafkatest.services.console_consumer import ConsoleConsumer
from kafkatest.tests.produce_consume_validate import ProduceConsumeValidateTest
Expand Down Expand Up @@ -135,16 +135,17 @@ def move_start_offset(self):
@matrix(
bounce_brokers=[True, False],
reassign_from_offset_zero=[True, False],
metadata_quorum=[quorum.zk],
metadata_quorum=[quorum.zk, quorum.isolated_kraft],
use_new_coordinator=[False]
)
@matrix(
bounce_brokers=[True, False],
reassign_from_offset_zero=[True, False],
metadata_quorum=[quorum.isolated_kraft],
use_new_coordinator=[True, False]
use_new_coordinator=[True],
group_protocol=consumer_group.all_group_protocols
)
def test_reassign_partitions(self, bounce_brokers, reassign_from_offset_zero, metadata_quorum, use_new_coordinator=False):
def test_reassign_partitions(self, bounce_brokers, reassign_from_offset_zero, metadata_quorum, use_new_coordinator=False, group_protocol=None):
"""Reassign partitions tests.
Setup: 1 zk, 4 kafka nodes, 1 topic with partitions=20, replication-factor=3,
and min.insync.replicas=3
Expand All @@ -167,7 +168,8 @@ def test_reassign_partitions(self, bounce_brokers, reassign_from_offset_zero, me
self.consumer = ConsoleConsumer(self.test_context, self.num_consumers,
self.kafka, self.topic,
consumer_timeout_ms=60000,
message_validator=is_int)
message_validator=is_int,
consumer_properties=consumer_group.maybe_set_group_protocol(group_protocol))

self.enable_idempotence=True
self.run_produce_consume_validate(core_test_action=lambda: self.reassign_partitions(bounce_brokers))