Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-16341: [backport] fix the LogValidator for non-compressed type (#15476) #15570

Merged
merged 5 commits into from Mar 23, 2024
Merged

KAFKA-16341: [backport] fix the LogValidator for non-compressed type (#15476) #15570

merged 5 commits into from Mar 23, 2024

Conversation

johnnychhsu
Copy link
Contributor

Context

We have merged the fix for non-compressed type in LogValidator, and we need to backport it to 3.6.
Jira: https://issues.apache.org/jira/browse/KAFKA-16341
Previous PR: #15476

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

johnnychhsu and others added 3 commits March 21, 2024 20:42
@johnnychhsu
KAFKA-16341 fix the LogValidator for non-compressed type (apache#15476)
6ad88dc 
- Fix the verifying logic. If it's LOG_APPEND_TIME, we choose the offset of the first record. Else, we choose the record with the maxTimeStamp.
- rename the shallowOffsetOfMaxTimestamp to offsetOfMaxTimestamp

Reviewers: Jun Rao <junrao@gmail.com>, Luke Chen <showuon@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
fix error
00e0246
fix error
8d9d496
chia7712
chia7712 reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed that there is a empty file

LogSegment.java

@johnnychhsu
Copy link
Contributor Author

oops, just remove it, thanks for the comment!

@chia7712 chia7712 marked this pull request as ready for review March 22, 2024 07:07
@chia7712
Copy link
Contributor

@johnnychhsu please check the failed tests

@omkreddy
Copy link
Contributor

@johnnychhsu Can we check if the failures are related,

@chia7712
Copy link
Contributor

run the failed tests and all pass on my local:

./gradlew cleanTest :streams:test --tests EOSUncleanShutdownIntegrationTest.shouldWorkWithUncleanShutdownWipeOutStateStore --tests EosV2UpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosV2 :tools:test --tests MetadataQuorumCommandTest.testDescribeQuorumReplicationSuccessful --tests MetadataQuorumCommandTest.testDescribeQuorumStatusSuccessful :storage:test --tests OffloadAndConsumeFromLeaderTest.executeTieredStorageTest :trogdor:test --tests CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated :connect:mirror:test --tests MirrorConnectorsIntegrationSSLTest.testReplicateFromLatest --tests MirrorConnectorsIntegrationTransactionsTest.testReplicateFromLatest --tests MirrorConnectorsIntegrationBaseTest.testSyncTopicConfigs --tests MirrorConnectorsIntegrationExactlyOnceTest.testReplicateSourceDefault :core:test --tests FetchFromFollowerIntegrationTest.testRackAwareRangeAssignor --tests DelegationTokenEndToEndAuthorizationWithOwnerTest.testNoProduceWithDescribeAcl --tests SaslScramSslEndToEndAuthorizationTest.testAuthentications :clients:test --tests SaslAuthenticatorFailurePositiveDelayTest.testDisabledSaslMechanism

@chia7712 chia7712 merged commit 95c14f8 into apache:3.6 Mar 23, 2024
1 check failed
omkreddy added a commit that referenced this pull request Mar 28, 2024
@omkreddy
Revert "KAFKA-16341 fix the LogValidator for non-compressed type (#15570
da1ee97 
)"

This reverts commit 95c14f8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@johnnychhsu @chia7712 @omkreddy