Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-16439: Update replication_replica_failure_test.py to support KIP-848’s group protocol config #15629

Merged
merged 1 commit into from
Apr 3, 2024
Merged

KAFKA-16439: Update replication_replica_failure_test.py to support KIP-848’s group protocol config #15629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 6 additions & 5 deletions tests/kafkatest/tests/core/replication_replica_failure_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from ducktape.mark import parametrize
from ducktape.mark.resource import cluster

from kafkatest.services.kafka import quorum
from kafkatest.services.kafka import quorum, consumer_group
from kafkatest.tests.end_to_end import EndToEndTest
from kafkatest.services.kafka import config_property
from kafkatest.services.trogdor.network_partition_fault_spec import NetworkPartitionFaultSpec
Expand All @@ -38,14 +38,15 @@ def __init__(self, test_context):

@cluster(num_nodes=7)
@matrix(
metadata_quorum=[quorum.zk],
metadata_quorum=[quorum.zk, quorum.isolated_kraft],
use_new_coordinator=[False]
)
@matrix(
metadata_quorum=[quorum.isolated_kraft],
use_new_coordinator=[True, False]
use_new_coordinator=[True],
group_protocol=consumer_group.all_group_protocols
)
def test_replication_with_replica_failure(self, metadata_quorum=quorum.zk, use_new_coordinator=False):
def test_replication_with_replica_failure(self, metadata_quorum=quorum.zk, use_new_coordinator=False, group_protocol=None):
"""
This test verifies that replication shrinks the ISR when a replica is not fetching anymore.
It also verifies that replication provides simple durability guarantees by checking that data acked by
Expand Down Expand Up @@ -90,7 +91,7 @@ def test_replication_with_replica_failure(self, metadata_quorum=quorum.zk, use_n
self.create_producer()
self.producer.start()

self.create_consumer()
self.create_consumer(group_protocol=group_protocol)
self.consumer.start()

self.await_startup()
Expand Down