Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: disable internal result emit throttling in TTD #15660

Merged
merged 3 commits into from Apr 19, 2024

Conversation

mjsax
Copy link
Member

@mjsax mjsax commented Apr 4, 2024

Kafka Streams DSL operators use internal wall-clock based throttling parameters for performance reasons. These configs make the usage of TTD difficult: users need to advance the mocked wall-clock time in their test code, or set these internal configs to zero.

To simplify testing, TDD should disable both configs automatically.

Kafka Streams DSL operators use internal wall-clock based throtteling
parameters for performance reasons. These configs make the usage of TTD
difficult: users need to advance the mocked wall-clock time in
their test code, or set these internal configs to zero.

To simplify testing, TDD should disable both configs automatically.
@mjsax mjsax added the streams label Apr 4, 2024
Copy link
Member

@lucasbru lucasbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mjsax mjsax merged commit 5783159 into apache:trunk Apr 19, 2024
1 check failed
@mjsax mjsax deleted the minor-tdd-disable-join-throttling branch April 19, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants