Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-16467: Add README to docs folder #15664

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

FrankYang0529
Copy link
Member

Add how to run local website to docs folder.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@FrankYang0529 FrankYang0529 changed the title KAFKA-16467: add docs README KAFKA-16467: Add README to docs folder Apr 5, 2024
Copy link
Contributor

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could improve in Kafka-site repo (where we put all the generated documents for all versions), and pointed this guide into here.

@FrankYang0529
Copy link
Member Author

Maybe we could improve in Kafka-site repo (where we put all the generated documents for all versions), and pointed this guide into here.

Hi @showuon, thanks for the suggestion. I created a PR in kafka-site apache/kafka-site#596. I will update this PR after kafka-site PR is merged.

Signed-off-by: PoAn Yang <payang@apache.org>
@FrankYang0529
Copy link
Member Author

Hi @showuon, I update README to point to kafka-site. Thank you.

Copy link
Contributor

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@showuon showuon merged commit 9387c7a into apache:trunk Apr 30, 2024
1 check failed
@FrankYang0529 FrankYang0529 deleted the KAFKA-16467 branch April 30, 2024 04:59
gongxuanzhang pushed a commit to gongxuanzhang/kafka that referenced this pull request Jun 12, 2024
Add how to run local website to docs folder.

Signed-off-by: PoAn Yang <payang@apache.org>

Reviewers: Luke Chen <showuon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants