KAFKA-16207; KRaft's internal log listener to update voter set #15671

jsancio · 2024-04-05T20:17:37Z

Adds support for the KafkaRaftClient to read the control records KRaftVersionRecord and VotersRecord in the snapshot and log. As the control records in the KRaft partition are read, the replica's known set of voters are updated. This change also contains the necessary changes to include the control records when a snapshot is generated by the KRaft state machine.

It is important to note that this commit changes the code and the in-memory state to track the sets of voters but it doesn't change any data that is externally exposed. It doesn't change the RPCs, data stored on disk or configuration.

When the KRaft replica starts the PartitionListener reads the latest snapshot and then log segments up to the LEO, updating the in-memory state as it reads KRaftVersionRecord and VotersRecord. When the replica (leader and follower) appends to the log, the PartitionListener catches up to the new LEO. When the replica truncates the log because of a diverging epoch, the PartitionListener also truncates the in-memory state to the new LEO. When the state machine generate a new snapshot the PartitionListener trims any prefix entries that are not needed. This is all done to minimize the amount of data tracked in-memory and to make sure that it matches the state on disk.

To implement the functionality described above this commit also makes the following changes:

Adds control records for KRaftVersionRecord and VotersRecord. KRaftVersionRecord describes the finalized kraft.version supported by all of the replicas. VotersRecords describes the set of voters at a specific offset.

Changes Kafka's feature version to support 0 as the smallest valid value. This is needed because the default value for kraft.version is 0.

Refactors FileRawSnapshotWriter so that it doesn't directly call the onSnapshotFrozen callback. It adds NotifyingRawSnapshotWriter for calling such callbacks. This reorganization is needed because in this change both the KafkaMetadataLog and the KafkaRaftClient need to react to snapshots getting frozen.

Cleans up KafkaRaftClient's initialization. Removes initialize from RaftClient - this is an implementation detail that doesn't need to be exposed in the interface. Removes RaftConfig.AddressSpec and simplifies the bootstrapping of the static voter's address. The bootstrapping of the address is delayed because of tests. We should be able to simplify this further in future commits.

Update the DumpLogSegment CLI to support the new control records KRaftVersionRecord and VotersRecord.

Fix the RecordsSnapshotReader implementations so that the iterator includes control records. RecordsIterator is extended to support reading the new control records.
Improve the BatchAccumulator implementation to allow multiple control records in one control batch. This is needed so that KRaft can make sure that VotersRecord is included in the same batch as the control record (KRaftVersionRecord) that upgrades the kraft.version to 1.

Add a History interface and default implementation TreeMapHistory. This is used to track all of the sets of voters between the latest snapshot and the LEO. This is needed so that KafkaRaftClient can query for the latest set of voters and so that KafkaRaftClient can include the correct set of voters when the state machine generates a new snapshot at a given offset.

Add a builder pattern for RecordsSnapshotWriter. The new builder pattern also implements including the KRaftVersionRecord and VotersRecord control records in the snapshot as necessary. A KRaftVersionRecord should be appended if the kraft.version is greater than 0 at the snapshot's offset. Similarly, a VotersRecord should be appended to the snapshot with the latest value up to the snapshot's offset.

…al-listener

…stener

…al-listener

hachikuji

Not all the way through, but thought I'd post the comments I have.

hachikuji · 2024-04-23T20:52:23Z

clients/src/main/java/org/apache/kafka/common/feature/BaseVersionRange.java

@@ -26,7 +26,7 @@
 /**
 * Represents an immutable basic version range using 2 attributes: min and max, each of type short.
 * The min and max attributes need to satisfy 2 rules:
- *  - they are each expected to be >= 1, as we only consider positive version values to be valid.


Was it a bug that we only allowed version 1 and above? I'm wondering if we really need to change it.

Yes. I think this was missed during the original implementation. The default value for any feature version is 0 but that cannot be expressed in the range of supported versions since it doesn't allow 0 as the min or max value.

hachikuji · 2024-04-23T20:54:48Z

clients/src/main/java/org/apache/kafka/common/record/ControlRecordType.java

    LEADER_CHANGE((short) 2),
    SNAPSHOT_HEADER((short) 3),
    SNAPSHOT_FOOTER((short) 4),

+    // KRaft membership changes messages
+    KRAFT_VERSION((short) 5),
+    VOTERS((short) 6),


nit: maybe we can start using the prefix consistently. KRAFT_VOTERS?

Sounds good. Fixed for KRAFT_VOTERS. I'll fix the rest in another PR.

hachikuji · 2024-04-23T21:05:06Z

clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java

+    ) {
+        try (MemoryRecordsBuilder builder = new MemoryRecordsBuilder(
+            buffer, RecordBatch.CURRENT_MAGIC_VALUE, CompressionType.NONE,
+            TimestampType.CREATE_TIME, initialOffset, timestamp,


nit: as long as we're separating args into lines, how about one argument per line?

hachikuji · 2024-04-23T21:07:42Z

clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java

+        ByteBuffer buffer,
+        VotersRecord votersRecord
+    ) {
+        writeVotersRecord(buffer, initialOffset, timestamp, leaderEpoch, votersRecord);


nit: This looks a little odd. We create two MemoryRecords instances. Why not just create one?

What do you mean we by "we create two MemoryRecords instances"?

We are discarding the MemoryRecords created by the builder and creating a new one.

Yeah. I see that. Looks like this is an existing issue with existing control record builders. Let me fix the ones that are specific for KRaft. We can fix the other ones in another PR.

clients/src/main/resources/common/message/VotersRecord.json

raft/src/main/java/org/apache/kafka/raft/internals/PartitionListener.java

hachikuji · 2024-04-25T19:22:38Z

raft/src/main/java/org/apache/kafka/raft/internals/PartitionListener.java

+    }
+
+    private void handleBatch(Batch<?> batch, OptionalLong overrideOffset) {
+        int index = 0;


I wonder if it is better to get the record offsets from the Batch object. This works because we know the partition is not compacted, but it still feels a bit suspicious.

The issue is that the offset in the batch are only meaningful when handling batches that come from the log. The offset of batches that come from the snapshot don't have any relation to the log offset. This is why we pass OptionalLong overrideOffset.

I change this name to offsetDelta.

raft/src/main/java/org/apache/kafka/raft/internals/History.java

raft/src/main/java/org/apache/kafka/raft/internals/TreeMapHistory.java

hachikuji · 2024-04-25T19:32:13Z

raft/src/main/java/org/apache/kafka/raft/internals/VoterSetHistory.java

+        Optional<History.Entry<VoterSet>> result = votersHistory.lastEntry();
+        if (result.isPresent()) return result;
+
+        return staticVoterSet.map(value -> new History.Entry<>(-1, value));


This seems a bit dangerous. Maybe we need a better type option. I think I had a comment about making History generic in the comparable type as well.

Hmm. I only implemented this so that VoterSetHistory can implement History. This method is not used by KRaftControlRecordStateMachine and I don't think we'll need it in the future. I'll just remove this method and removeimplements History.

…al-listener

hachikuji · 2024-04-29T17:52:40Z

core/src/main/scala/kafka/raft/RaftManager.scala

+    client.initialize(
+      controllerQuorumVotersFuture.get(),
+      config.controllerListenerNames.head,
+      new FileBasedStateStore(new File(dataDir, "quorum-state")),


Maybe we can have a constant for the file name. Not sure if it is used elsewhere, but it would be nice to have a nice descriptive name.

hachikuji · 2024-04-29T18:24:56Z

raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java

+        return parseVoterConnections(voterEntries, false).keySet();
+    }
+
+    private static Map<Integer, InetSocketAddress> parseVoterConnections(List<String> voterEntries, boolean routableOnly) {


nit: I think requireRoutableAddresses might convey the expectation more clearly.

hachikuji · 2024-04-29T20:23:49Z

raft/src/main/java/org/apache/kafka/raft/ReplicatedLog.java

@@ -261,7 +260,7 @@ default long truncateToEndOffset(OffsetAndEpoch endOffset) {
     * @param snapshotId the end offset and epoch that identifies the snapshot
     * @return a writable snapshot if it doesn't already exist
     */
-    Optional<RawSnapshotWriter> storeSnapshot(OffsetAndEpoch snapshotId);
+    Optional<RawSnapshotWriter> createNewSnapshotUnchecked(OffsetAndEpoch snapshotId);


Do we need the method? What would happen if the leader did violate the expected invariant? Would this data structure update itself to remain consistent?

hachikuji · 2024-04-29T20:41:38Z

raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java

     */
-    private void appendControlMessage(Function<ByteBuffer, MemoryRecords> valueCreator) {
+    public void appendControlMessages(Function<ByteBuffer, CreatedRecords> valueCreator) {


Since we have made this public, I wonder if it would be useful to validate that the created batch is in fact a control batch.

Okay, I was trying to avoid decoding the MemoryRecords. if we are going to read the first batch, we don't even need CreatedRecords.

hachikuji · 2024-04-29T20:43:16Z

raft/src/main/java/org/apache/kafka/raft/internals/History.java

+/**
+ * A object tracks values of {@code T} at different offsets.
+ */
+public interface History<T> {


Ok. In that case, perhaps we can qualify the general History name. Perhaps it should be RecordHistory or LogHistory or something like that?

hachikuji · 2024-04-30T21:10:26Z

raft/src/test/java/org/apache/kafka/raft/internals/VoterSetHistoryTest.java

+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+final public class VoterSetHistoryTest {


Should we have some cases where we try to add a non-overlapping voter set?

Yes. Good catch. Added two more tests.

hachikuji · 2024-04-30T21:16:54Z

raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java

    private final RaftMetadataLogCleanerManager snapshotCleaner;

    private final Map<Listener<T>, ListenerContext> listenerContexts = new IdentityHashMap<>();
    private final ConcurrentLinkedQueue<Registration<T>> pendingRegistrations = new ConcurrentLinkedQueue<>();

+    // These components need to be initialized by the method initialize() because they depend on the voter set
+    /*
+     * The key invariant for the kraft control record state machine is that it has always read to the LEO. This is achived by:


nit: achieved

hachikuji · 2024-04-30T21:23:49Z

raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java

+        Map<Integer, InetSocketAddress> voterAddresses,
+        String listenerName,
+        QuorumStateStore quorumStateStore,
+        Metrics metrics


Why do we need to delay initialization of metrics?

I can feel that the parameters for this method might grow over time. Perhaps we should package it up into some kind of initialization object.

Yeah. I am also not happy with this move. We only do this delay initialization because of integration tests (QuorumTestHarness, KRaftClusterTestKit). This is not needed by **/src/main.

Once we have KIP-853 fully implemented, I should be able to fix the integration tests to not use the static voter set and the delayed initialization.

I create Remove delayed initialization because of static voter set to track this work.

hachikuji · 2024-04-30T21:25:00Z

raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java

+        Metrics metrics
+    ) {
+        partitionState = new KRaftControlRecordStateMachine(
+            Optional.of(VoterSet.fromAddressSpecs(listenerName, voterAddresses)),


nit: maybe we should rename the method fromInetSocketAddresses or something like that?

hachikuji · 2024-04-30T21:33:08Z

raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java

+        }
+
+        return log.createNewSnapshot(snapshotId).map(writer -> {
+            long lastContainedLogOffset = snapshotId.offset() - 1;


nit: maybe we could have a helper for this logic

Yes. I have this issue KAFKA-14620 to introduce the SnapshotId type. I can fix this on that PR.

…al-listener

hachikuji

LGTM

…e#15671) Adds support for the KafkaRaftClient to read the control records KRaftVersionRecord and VotersRecord in the snapshot and log. As the control records in the KRaft partition are read, the replica's known set of voters are updated. This change also contains the necessary changes to include the control records when a snapshot is generated by the KRaft state machine. It is important to note that this commit changes the code and the in-memory state to track the sets of voters but it doesn't change any data that is externally exposed. It doesn't change the RPCs, data stored on disk or configuration. When the KRaft replica starts the PartitionListener reads the latest snapshot and then log segments up to the LEO, updating the in-memory state as it reads KRaftVersionRecord and VotersRecord. When the replica (leader and follower) appends to the log, the PartitionListener catches up to the new LEO. When the replica truncates the log because of a diverging epoch, the PartitionListener also truncates the in-memory state to the new LEO. When the state machine generate a new snapshot the PartitionListener trims any prefix entries that are not needed. This is all done to minimize the amount of data tracked in-memory and to make sure that it matches the state on disk. To implement the functionality described above this commit also makes the following changes: Adds control records for KRaftVersionRecord and VotersRecord. KRaftVersionRecord describes the finalized kraft.version supported by all of the replicas. VotersRecords describes the set of voters at a specific offset. Changes Kafka's feature version to support 0 as the smallest valid value. This is needed because the default value for kraft.version is 0. Refactors FileRawSnapshotWriter so that it doesn't directly call the onSnapshotFrozen callback. It adds NotifyingRawSnapshotWriter for calling such callbacks. This reorganization is needed because in this change both the KafkaMetadataLog and the KafkaRaftClient need to react to snapshots getting frozen. Cleans up KafkaRaftClient's initialization. Removes initialize from RaftClient - this is an implementation detail that doesn't need to be exposed in the interface. Removes RaftConfig.AddressSpec and simplifies the bootstrapping of the static voter's address. The bootstrapping of the address is delayed because of tests. We should be able to simplify this further in future commits. Update the DumpLogSegment CLI to support the new control records KRaftVersionRecord and VotersRecord. Fix the RecordsSnapshotReader implementations so that the iterator includes control records. RecordsIterator is extended to support reading the new control records. Improve the BatchAccumulator implementation to allow multiple control records in one control batch. This is needed so that KRaft can make sure that VotersRecord is included in the same batch as the control record (KRaftVersionRecord) that upgrades the kraft.version to 1. Add a History interface and default implementation TreeMapHistory. This is used to track all of the sets of voters between the latest snapshot and the LEO. This is needed so that KafkaRaftClient can query for the latest set of voters and so that KafkaRaftClient can include the correct set of voters when the state machine generates a new snapshot at a given offset. Add a builder pattern for RecordsSnapshotWriter. The new builder pattern also implements including the KRaftVersionRecord and VotersRecord control records in the snapshot as necessary. A KRaftVersionRecord should be appended if the kraft.version is greater than 0 at the snapshot's offset. Similarly, a VotersRecord should be appended to the snapshot with the latest value up to the snapshot's offset. Reviewers: Jason Gustafson <jason@confluent.io>

junrao

@jsancio : Thanks for the PR and sorry for the late review. Made a pass of non-testing files and left a few comments.

junrao · 2024-05-03T22:19:00Z

clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java

    }

-    private static void writeSnapshotFooterRecord(
-        ByteBuffer buffer,
+    private static MemoryRecordsBuilder createKraftControlReccordBuilder(


typo Reccord

I submitted this #15912 as a followup to these comments.

junrao · 2024-05-03T22:43:35Z

raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java

@@ -1470,6 +1524,10 @@ private boolean handleFetchSnapshotResponse(
                    quorum.leaderIdOrSentinel()
                );

+                // This will aways reload the snapshot because the internal next offset


junrao · 2024-05-03T23:10:09Z

raft/src/main/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachine.java

+ * This type keeps track of changes to the finalized kraft.version and the sets of voters between
+ * the latest snasphot and the log end offset.
+ *
+ * The are two actors/threads for this type. One is the KRaft driver which indirectly call a lot of


The are => There are

junrao · 2024-05-03T23:36:20Z

raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java

+        // so there are no unknown voter connections. Report this metric as 0.
+        kafkaRaftMetrics.updateNumUnknownVoterConnections(0);
+
+        VoterSet lastVoterSet = partitionState.lastVoterSet();


Would it be better to move this to before line 389 to avoid calling partitionState.lastVoterSet() multiple times?

junrao · 2024-05-06T19:02:14Z

raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java

@@ -245,6 +255,42 @@ private void appendControlMessage(Function<ByteBuffer, MemoryRecords> valueCreat
        }
    }

+    private int validateMemoryRecordAndReturnCount(MemoryRecords memoryRecord) {
+        // Confirm that it is at most one batch and it is a control record


I guess we support a batch with more than one control record?

Yeah. I fixed the comment and the implementation.

junrao · 2024-05-06T21:15:20Z

raft/src/main/java/org/apache/kafka/raft/internals/VoterSetHistory.java

+ * A type for storing the historical value of the set of voters.
+ *
+ * This type can be use to keep track in-memory the sets for voters stored in the latest snapshot
+ * and log. This is useful when generating a new snapshot at a given offset or when evaulating


typo evaulating

junrao · 2024-05-06T21:15:58Z

raft/src/main/java/org/apache/kafka/raft/internals/VoterSetHistory.java

+     * offset of all previous calls to this method.
+     *
+     * @param offset the offset
+     * @param value the value to store


value => voters

junrao · 2024-05-06T21:18:17Z

raft/src/main/java/org/apache/kafka/raft/internals/VoterSetHistory.java

+     * Computes the value of the voter set at a given offset.
+     *
+     * This function will only return values provided through {@code addAt} and it would never
+     * include the {@code staticVoterSet} provided through the constructoer.


typo constructoer

junrao · 2024-05-06T21:46:24Z

raft/src/main/java/org/apache/kafka/raft/ReplicatedLog.java

-     * Snapshots created using this method will be validated against the existing snapshots
-     * and the replicated log.
+     * The snapshot id will be validated against the existing snapshots and the log. The snapshot id
+     * must not alread exist, it must be greater than the log start offset, it must be less than


typo alread

junrao · 2024-05-06T21:54:10Z

raft/src/main/java/org/apache/kafka/snapshot/RecordsSnapshotReader.java

-            if (!batch.records().isEmpty()) {
-                return Optional.of(batch);
-            }
+            return Optional.of(batch);


With this change, the while statement doesn't loop. Should we remove while?

Yes. Good catch. We need an if statement. I updated the java doc too.

…e#15671) Adds support for the KafkaRaftClient to read the control records KRaftVersionRecord and VotersRecord in the snapshot and log. As the control records in the KRaft partition are read, the replica's known set of voters are updated. This change also contains the necessary changes to include the control records when a snapshot is generated by the KRaft state machine. It is important to note that this commit changes the code and the in-memory state to track the sets of voters but it doesn't change any data that is externally exposed. It doesn't change the RPCs, data stored on disk or configuration. When the KRaft replica starts the PartitionListener reads the latest snapshot and then log segments up to the LEO, updating the in-memory state as it reads KRaftVersionRecord and VotersRecord. When the replica (leader and follower) appends to the log, the PartitionListener catches up to the new LEO. When the replica truncates the log because of a diverging epoch, the PartitionListener also truncates the in-memory state to the new LEO. When the state machine generate a new snapshot the PartitionListener trims any prefix entries that are not needed. This is all done to minimize the amount of data tracked in-memory and to make sure that it matches the state on disk. To implement the functionality described above this commit also makes the following changes: Adds control records for KRaftVersionRecord and VotersRecord. KRaftVersionRecord describes the finalized kraft.version supported by all of the replicas. VotersRecords describes the set of voters at a specific offset. Changes Kafka's feature version to support 0 as the smallest valid value. This is needed because the default value for kraft.version is 0. Refactors FileRawSnapshotWriter so that it doesn't directly call the onSnapshotFrozen callback. It adds NotifyingRawSnapshotWriter for calling such callbacks. This reorganization is needed because in this change both the KafkaMetadataLog and the KafkaRaftClient need to react to snapshots getting frozen. Cleans up KafkaRaftClient's initialization. Removes initialize from RaftClient - this is an implementation detail that doesn't need to be exposed in the interface. Removes RaftConfig.AddressSpec and simplifies the bootstrapping of the static voter's address. The bootstrapping of the address is delayed because of tests. We should be able to simplify this further in future commits. Update the DumpLogSegment CLI to support the new control records KRaftVersionRecord and VotersRecord. Fix the RecordsSnapshotReader implementations so that the iterator includes control records. RecordsIterator is extended to support reading the new control records. Improve the BatchAccumulator implementation to allow multiple control records in one control batch. This is needed so that KRaft can make sure that VotersRecord is included in the same batch as the control record (KRaftVersionRecord) that upgrades the kraft.version to 1. Add a History interface and default implementation TreeMapHistory. This is used to track all of the sets of voters between the latest snapshot and the LEO. This is needed so that KafkaRaftClient can query for the latest set of voters and so that KafkaRaftClient can include the correct set of voters when the state machine generates a new snapshot at a given offset. Add a builder pattern for RecordsSnapshotWriter. The new builder pattern also implements including the KRaftVersionRecord and VotersRecord control records in the snapshot as necessary. A KRaftVersionRecord should be appended if the kraft.version is greater than 0 at the snapshot's offset. Similarly, a VotersRecord should be appended to the snapshot with the latest value up to the snapshot's offset. Reviewers: Jason Gustafson <jason@confluent.io>

jsancio added 10 commits January 30, 2024 16:28

KAFKA-16207; Add KRaftVersionRecord and VotersRecord

dd84479

Some observation while reviewing the KIP and implementation

87a43c6

Fix compilation errors

c9de8a1

KAFKA-16207; Match KIP schema

54b164e

KAFKA-16207; Implement VoterSet and VoterSetHistory

04fcf4c

KAFKA-16207; Add impl for internal log listener

702e739

KAFKA-16207; Add historical kraft version

fae8b84

KAFKA-16207; Import refactor to delay voter address evaluation

25d9dfd

Merge remote-tracking branch 'upstream/trunk' into kafka-16207-intern…

b3e65bd

…al-listener

KAFKA-16207; Fix core and metadata after raft changes

9a6b4c2

jsancio added kraft KIP-853 labels Apr 5, 2024

jsancio added 18 commits April 5, 2024 13:48

KAFKA-16207; More voter parsing clean ups

24661b1

KAFKA-16207; User the voter set from the config or log

cd3277c

KAFKA-16207; Return node id before calling initialize

f3a0fcd

KAFKA-16207; Add a builder for record snaapshot writer

08e1831

KAFKA-16207; Include kraft.version and voter set in the snapshots

89ac698

KAFKA-16207; Use SupportedVersionRange

2889b42

KAFKA-16207; Fix version range documentation

1188b94

KAFKA-16207; Snapshots should return control records

92909fb

KAFKA-16207; Document internal listener invariant

dd28ef4

KAFKA-16207; Update some of the documentation

deb7920

KAFKA-16207; Fix cluster snapshot test

0db1a06

KAFKA-16207; Implement truncating and prefix trimming the internal li…

ab1886a

…stener

KAFKA-16207; Finish documenting all of the type and methods

a962188

KAFKA-16207; Implement some of the unittest

1829e06

KAFKA-16207; Add 2 more test suites

a108e9c

KAFKA-16207; Make the control batch buffer configurable

795858f

KAFKA-16207; Add tests for snapshot builder

a79660e

KAFKA-16207; Add test for internal partition listener

625aabd

Merge remote-tracking branch 'upstream/trunk' into kafka-16207-intern…

855a13e

…al-listener

jsancio marked this pull request as ready for review April 17, 2024 14:57

jsancio mentioned this pull request Apr 22, 2024

KAFKA-16526; Add quorum state v1 #15781

Closed

3 tasks

jsancio added 2 commits April 22, 2024 10:14

Merge remote-tracking branch 'upstream/trunk' into kafka-16207-intern…

629c7da

…al-listener

Merge remote-tracking branch 'upstream/trunk' into kafka-16207-intern…

bc26f59

…al-listener

hachikuji reviewed Apr 25, 2024

View reviewed changes

jsancio added 5 commits April 26, 2024 09:34

KAFKA-16207; Use directory id instead of uuid

b6fc7f6

Merge remote-tracking branch 'upstream/trunk' into kafka-16207-intern…

742c969

…al-listener

KAFKA-16207; Many fixes and improvements

e55564d

KAFKA-16207; Rename PartitionListener

de19062

Merge remote-tracking branch 'upstream/trunk' into kafka-16207-intern…

66c3793

…al-listener

hachikuji reviewed Apr 30, 2024

View reviewed changes

jsancio added 4 commits May 1, 2024 15:05

KAFKA-16207; Review feedback changes

c821a83

KAFKA-16207; Better validate the control records in the accumulator

c2a7a9a

Merge remote-tracking branch 'upstream/trunk' into kafka-16207-intern…

d1c17e0

…al-listener

KAFKA-16207; Minor fix

bc80295

hachikuji approved these changes May 3, 2024

View reviewed changes

KAFKA-16207; kraft version default of 1 for tests

c363bf1

jsancio merged commit bfe81d6 into apache:trunk May 4, 2024
1 check failed

jsancio deleted the kafka-16207-internal-listener branch May 4, 2024 19:43

junrao reviewed May 6, 2024

View reviewed changes

KAFKA-16207; KRaft's internal log listener to update voter set #15671

KAFKA-16207; KRaft's internal log listener to update voter set #15671

Conversation

jsancio commented Apr 5, 2024 • edited

hachikuji left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsancio Apr 25, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hachikuji left a comment

Choose a reason for hiding this comment

junrao left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsancio commented Apr 5, 2024 •

edited

jsancio Apr 25, 2024 •

edited