KAFKA-16556: SubscriptionState should not prematurely reset 'pending' partitions #15724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… partitions Partitions that are marked as pendingOnAssignedCallback should not be reset in resetInitializingPositions. Pending partitions are omitted from the set returned by initializingPartitions(). As a result, the Consumer does not include them in the set of partitions for which it attempts to load committed offsets. The code used by the Consumer to reset positions should likewise omit them from the set of partitions to reset.
|
@lucasbru—please kindly take a look at this issue that's occasionally causing consumers to ignore committed offsets. The result is the consumer resets the partition's position back to 0, causing reprocessing of messages. |
kirktrue
deleted the
KAFKA-16556-skip-position-reset-for-pending-partitions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partitions that are marked as
pendingOnAssignedCallbackshould not be reset inresetInitializingPositions(). Pending partitions are omitted from the set returned byinitializingPartitions(). As a result, the Consumer does not include them in the set of partitions for which it attempts to load committed offsets. The code used by the Consumer to reset positions (resetInitializingPositions()) should likewise skip partitions marked as pending.Committer Checklist (excluded from commit message)