Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-16571: reassign_partitions_test.bounce_brokers should wait for messages to be sent to every partition #15739

Merged
merged 4 commits into from Apr 25, 2024

Conversation

jolshan
Copy link
Contributor

@jolshan jolshan commented Apr 16, 2024

Added the check before the reassignment occurs and we start bouncing brokers.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@jolshan jolshan marked this pull request as ready for review April 16, 2024 23:02
Copy link
Contributor

@splett2 splett2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm i guess

@jolshan
Copy link
Contributor Author

jolshan commented Apr 16, 2024

Hmmm -- I ran the test and it is not working. I will debug 👍

@jolshan
Copy link
Contributor Author

jolshan commented Apr 17, 2024

I ran the test (reassing_partitions_test) 3 times and it seems to be working ok.

Copy link
Contributor

@splett2 splett2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm i guess

Copy link
Contributor

@dajac dajac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this.

@jolshan jolshan merged commit a7ceacd into apache:trunk Apr 25, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants