Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-16461: New consumer fails to consume records in security_test.py system test #15746

Merged
merged 1 commit into from Apr 23, 2024

Conversation

kirktrue
Copy link
Contributor

The system test was failing because the VerifiableConsumer failed with a NullPointerException during startup. The reason for the NPE was an attempt to put a null as the value of --group-remote-assignor in the Consumer's configuration.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

…y system test

The system test was failing because the VerifiableConsumer failed with a NullPointerException during startup. The reason for the NPE was an attempt to put a null as the value of --group-remote-assignor in the Properties.
Copy link
Contributor

@lianetm lianetm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, the consumer has a default but it's null, we want to leave the new coordinator choose the default assignor. Thanks for the fix! LGTM

@kirktrue
Copy link
Contributor Author

@lucasbru—Can you review? Thanks!

Copy link
Member

@lucasbru lucasbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@lucasbru lucasbru merged commit 53f9675 into apache:trunk Apr 23, 2024
1 check failed
@kirktrue kirktrue deleted the KAFKA-16461-fix_security_test_npe branch April 23, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants