Add Integration tests for the the KIP-966 #15759
Open
+433
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mumrah @artemlivshits Can you help take a look? |
Comment on lines
+264
to
+266
| Thread.sleep(1000); | ||
| records = consumer.poll(Duration.ofSeconds(1L)); | ||
| assertEquals(0, records.count()); |
There was a problem hiding this comment.
I wonder if we should just check that produce with acks=all fails with the not enough replicas error. Trying to consume the records adds time to the test run (the sleep is real time not mock time) and doesn't guarantee that we didn't consume the record yet because HWM didn't move and not for some other reason (e.g. cluster is just slow).
There was a problem hiding this comment.
It is a valid concern. But I don't have an idea how to get around this.
With ack=all, the producer request will be rejected. Then we don't know if restoring the min ISR can unblock the HWM with no offsets to be forwarded.
soarez
reviewed
Apr 27, 2024
core/src/test/java/kafka/server/integration/EligibleLeaderReplicasIntegrationTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/kafka/server/integration/EligibleLeaderReplicasIntegrationTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/KAFKA-15579