KAFKA-3922: add constructor to AbstractStream class #1581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM overall. Could you change your comment to have a more meaningful description since it will be included in the commit log? |
This copy-constructor allow to access protected variables from subclasses. It should be used to extend KStreamImpl and KTableImpl classes by implementing a decorator pattern.
asfgit
pushed a commit
that referenced
this pull request
Jul 19, 2016
https://issues.apache.org/jira/browse/KAFKA-3922 KAFKA-3922 add copy-constructor to AbstractStream class This copy-constructor allow to access protected variables from subclasses. It should be used to extend KStreamImpl and KTableImpl classes by implementing a decorator pattern. Author: Florian Hussonnois <florian.hussonnois@gmail.com> Reviewers: Guozhang Wang <wangguoz@gmail.com> Closes #1581 from fhussonnois/KAFKA-3922 (cherry picked from commit b418922) Signed-off-by: Guozhang Wang <wangguoz@gmail.com>
|
LGTM. Merged to trunk and 0.10.0, thanks @fhussonnois ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/KAFKA-3922
KAFKA-3922 add copy-constructor to AbstractStream class
This copy-constructor allow to access protected variables from subclasses.
It should be used to extend KStreamImpl and KTableImpl classes by implementing a decorator pattern.