Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-16589: Consider removing ClusterInstance#createAdminClient since callers are not sure whether they need to call close #15815

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

FrankYang0529
Copy link
Member

Sometimes we close the admin created by createAdminClient, and sometimes we don't. That is not a true problem since the ClusterInstance will call close when stopping.

However, that cause a lot of inconsistent code, and in fact it does not save much time since creating a Admin is not a hard work. We can get bootstrapServers and bootstrapControllers from ClusterInstance easily.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

…stance#adminConfigs

Signed-off-by: PoAn Yang <payang@apache.org>
@chia7712
Copy link
Contributor

We are doing the migration so can this PR get pending before we see more use cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants