KAFKA-16589: Consider removing ClusterInstance#createAdminClient
since callers are not sure whether they need to call close
#15815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we close the admin created by
createAdminClient
, and sometimes we don't. That is not a true problem since theClusterInstance
will callclose
when stopping.However, that cause a lot of inconsistent code, and in fact it does not save much time since creating a Admin is not a hard work. We can get
bootstrapServers
andbootstrapControllers
fromClusterInstance
easily.Committer Checklist (excluded from commit message)