Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-16627: Remove ClusterConfig parameter in BeforeEach and AfterEach #15824

Merged
merged 3 commits into from Apr 30, 2024

Conversation

brandboat
Copy link
Member

related to KAFKA-16627

In the past we modify configs like server broker properties by modifying the ClusterConfig reference passed to BeforeEach and AfterEach based on the requirements of the tests.
While after KAFKA-16560, the ClusterConfig become immutable, modify the ClusterConfig reference no longer reflects any changes to the test cluster. Then pass ClusterConfig to BeforeEach and AfterEach become redundant.

This pr directly remove the behavior that pass ClusterConfig to all test methods and before/after each method.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@brandboat brandboat marked this pull request as ready for review April 28, 2024 16:36
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandboat thanks for this patch. Could you also revise the following docs to remind developers that ClusterConfig is immutable now!!!

  1. * ClusterConfig: a mutable cluster configuration, includes cluster type, number of brokers, properties, etc

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 merged commit 6d436a8 into apache:trunk Apr 30, 2024
1 check failed
@brandboat brandboat deleted the KAFKA-16627 branch April 30, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants