KAFKA-10199: Accept only one task per exception in queue for failed tasks #15849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…led tasks Currently, the state updater writes multiple tasks per exception in the output queue for failed tasks. To add the functionality to remove tasks synchronously from the state updater, it is simpler that each element of the output queue for failed tasks holds one single task. This commit refactors the class that holds exceptions and failed tasks in the state updater -- i.e., ExceptionAndTasks -- to just hold one single task.
lucasbru
approved these changes
May 3, 2024
lucasbru
approved these changes
May 3, 2024
|
Failures are unrelated! |
gongxuanzhang
pushed a commit
to gongxuanzhang/kafka
that referenced
this pull request
Jun 12, 2024
…led tasks (apache#15849) Currently, the state updater writes multiple tasks per exception in the output queue for failed tasks. To add the functionality to remove tasks synchronously from the state updater, it is simpler that each element of the output queue for failed tasks holds one single task. This commit refactors the class that holds exceptions and failed tasks in the state updater -- i.e., ExceptionAndTasks -- to just hold one single task. Reviewers: Lucas Brutschy <lbrutschy@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the state updater writes multiple tasks per exception in the output queue for failed tasks. To add the functionality to remove tasks synchronously from the state updater, it is simpler that each element of the output queue for failed tasks holds one single task.
This commit refactors the class that holds exceptions and failed tasks in the state updater -- i.e., ExceptionAndTasks -- to just hold one single task.
Committer Checklist (excluded from commit message)