KAFKA-16652: add unit test for ClusterTemplate offering zero ClusterConfig #15862
+42
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soarez
reviewed
May 5, 2024
core/src/test/java/kafka/test/junit/ClusterTestExtensionsUnitTest.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
May 10, 2024
core/src/test/java/kafka/test/junit/ClusterTestExtensionsUnitTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/kafka/test/junit/ClusterTestExtensionsUnitTest.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
May 27, 2024
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| public class ClusterTestExtensionsUnitTest { | ||
|
|
||
| static class StubTest { |
There was a problem hiding this comment.
It seems this nested class is unnecessary. For example:
static List<ClusterConfig> cfgEmpty() {
return new ArrayList<ClusterConfig>();
}
@SuppressWarnings({"unchecked", "rawtypes"})
private ExtensionContext buildExtensionContext(String methodName) throws Exception {
ExtensionContext extensionContext = mock(ExtensionContext.class);
Class clazz = ClusterTestExtensionsUnitTest.class;
Method method = clazz.getDeclaredMethod(methodName);
when(extensionContext.getRequiredTestClass()).thenReturn(clazz);
when(extensionContext.getRequiredTestMethod()).thenReturn(method);
return extensionContext;
}BTW, methodName is always "cfgEmpty", so maybe we can remove it from input argument.
There was a problem hiding this comment.
In my mind, keeping the argument will make this function reusable if needed.
|
@TaiJuWu Could you please rebase code? |
chia7712
reviewed
May 29, 2024
core/src/test/java/kafka/test/junit/ClusterTestExtensionsUnitTest.java
Outdated
Show resolved
Hide resolved
chia7712
approved these changes
May 31, 2024
chia7712
reviewed
May 31, 2024
| when(annot.value()).thenReturn("").thenReturn(" "); | ||
| when(annot.value()).thenReturn("").thenReturn(" ").thenReturn("cfgEmpty"); | ||
|
|
||
| Assertions.assertEquals( |
There was a problem hiding this comment.
This test is equal to next one, right?
There was a problem hiding this comment.
Yes, but the first one is for @clusterTemplate(""), the other is @ClusterTemplate(" ").
chia7712
approved these changes
Jun 1, 2024
wernerdv
pushed a commit
to wernerdv/kafka
that referenced
this pull request
Jun 3, 2024
…nfig (apache#15862) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*More detailed description of your change,
refactor processClusterTemplate and add unit test for empty config
*Summary of testing strategy (including rationale)
Committer Checklist (excluded from commit message)