KAFKA-10199: Revoke tasks from state updater with new remove #15871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadonna
force-pushed
the
stateupdater_revocation_with_new_remove
branch
from
b466ea0
to
3c5f08e
Compare
lucasbru
reviewed
May 7, 2024
| @@ -623,6 +623,21 @@ private void addToTasksToClose(final Map<TaskId, CompletableFuture<StateUpdater. | |||
| }); | |||
| } | |||
|
|
|||
| private void iterateAndActOnRemovedTask(final Map<TaskId, CompletableFuture<StateUpdater.RemovedTaskResult>> futures, | |||
There was a problem hiding this comment.
Are we going to reuse this method? Otherwise, I find this a bit too abstract, and I'd just inline it.
There was a problem hiding this comment.
Yes, we are going to re-use it. Stay tuned!
There was a problem hiding this comment.
OK then. Let's continue to have it as a method.
Uses the new remove operation of the state updater that returns a future to remove revoked tasks from the state udpater.
cadonna
force-pushed
the
stateupdater_revocation_with_new_remove
branch
from
d3cca11
to
be0567a
Compare
gongxuanzhang
pushed a commit
to gongxuanzhang/kafka
that referenced
this pull request
Jun 12, 2024
…15871) Uses the new remove operation of the state updater that returns a future to remove revoked tasks from the state updater. Reviewer: Lucas Brutschy <lbrutschy@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the new remove operation of the state updater that returns
a future to remove revoked tasks from the state udpater.
Committer Checklist (excluded from commit message)