Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Upgrade scala-logging to 3.9.5 #15914

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

viktorsomogyi
Copy link
Contributor

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@viktorsomogyi viktorsomogyi requested a review from ijuma May 10, 2024 08:46
@viktorsomogyi
Copy link
Contributor Author

@ijuma would you please review this small PR?

@sjhajharia
Copy link
Contributor

@viktorsomogyi
I see that both scala-logging 3.9.5 and 3.9.4 have the same vulnerability coming in from [CVE-2023-6378]. Is there a reason thus that we want this upgrade?

ref:
https://mvnrepository.com/artifact/com.typesafe.scala-logging/scala-logging_3/3.9.5
https://mvnrepository.com/artifact/com.typesafe.scala-logging/scala-logging_3/3.9.4

Thanks!

@viktorsomogyi
Copy link
Contributor Author

@sjhajharia thanks for highlighting the CVE, it's important to consider them. This version bump doesn't fix the CVE indeed as you highlighted, but it is present in older versions too, so it doesn't really make it worse either.
My reason for this version bump is simply to get in sync with our downstream software and also 3.9.5 depends on slf4j-1.7.36 which is Kafka's current slf4j dependency, whereas 3.9.4 depends on slf4j-1.7.30. So in this sense it's more about aligning dependencies rather than fixing CVEs.

@viktorsomogyi
Copy link
Contributor Author

@urbandan @akatona84 would you please review this?

Copy link
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viktorsomogyi viktorsomogyi merged commit a68a1cc into apache:trunk Jun 3, 2024
1 check failed
wernerdv pushed a commit to wernerdv/kafka that referenced this pull request Jun 3, 2024
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Andras Katona <katonaan@gmail.com>, Sanskar Jhajharia <jhajharia.sanskar@gmail.com>
TaiJuWu pushed a commit to TaiJuWu/kafka that referenced this pull request Jun 8, 2024
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Andras Katona <katonaan@gmail.com>, Sanskar Jhajharia <jhajharia.sanskar@gmail.com>
gongxuanzhang pushed a commit to gongxuanzhang/kafka that referenced this pull request Jun 12, 2024
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Andras Katona <katonaan@gmail.com>, Sanskar Jhajharia <jhajharia.sanskar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants