-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-16654:Refactor kafka.test.annotation.Type and ClusterTestExtensions #15916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TaiJuWu thanks for this patch. some comments are left.
@TaiJuWu please fix the conflicts :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TaiJuWu thanks for updated PR.
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java
Outdated
Show resolved
Hide resolved
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TaiJuWu nice patch. it is almost prefect.
@TaiJuWu Please update all tests using |
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ions (apache#15916) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
…ions (apache#15916) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
…ions (apache#15916) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
…ions (apache#15916) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
*More detailed description of your change,
KAFKA-16654
*Summary of testing strategy (including rationale)
CI test.
Committer Checklist (excluded from commit message)