Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-16703: Close serverChannel in SocketServer if unable to bind to a port #15923

Merged
merged 2 commits into from
May 14, 2024
Merged

KAFKA-16703: Close serverChannel in SocketServer if unable to bind to a port #15923

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f35aec
KAFKA-16703: Close serverChannel in SocketServer if unable to bind to…
gharris1727 May 10, 2024
cb95f00
fixup: move other serverChannel methods into try-catch
gharris1727 May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions core/src/main/scala/kafka/network/SocketServer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,15 +725,15 @@ private[kafka] abstract class Acceptor(val socketServer: SocketServer,
else
new InetSocketAddress(host, port)
val serverChannel = ServerSocketChannel.open()
serverChannel.configureBlocking(false)
if (recvBufferSize != Selectable.USE_DEFAULT_BUFFER_SIZE)
serverChannel.socket().setReceiveBufferSize(recvBufferSize)

try {
serverChannel.configureBlocking(false)
if (recvBufferSize != Selectable.USE_DEFAULT_BUFFER_SIZE)
serverChannel.socket().setReceiveBufferSize(recvBufferSize)
serverChannel.socket.bind(socketAddress, listenBacklogSize)
info(s"Awaiting socket connections on ${socketAddress.getHostString}:${serverChannel.socket.getLocalPort}.")
} catch {
case e: SocketException =>
Utils.closeQuietly(serverChannel, "server socket")
throw new KafkaException(s"Socket server failed to bind to ${socketAddress.getHostString}:$port: ${e.getMessage}.", e)
}
serverChannel
Expand Down