KAFKA-16789: Fix thread leak detection for event handler threads #15984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates `TestUtils::verifyNoUnexpectedThreads` to check for all event queue threads instead of the incorrect QuorumController thread. Also updated `KafkaEventQueueTest` to use try-with-resources to ensure threads get closed and to use LoggerContext with the current test name as the logPrefix for easier debugging.
chia7712
reviewed
May 17, 2024
| @@ -1872,7 +1872,7 @@ object TestUtils extends Logging { | |||
| AdminClientUnitTestEnv.kafkaAdminClientNetworkThreadPrefix(), | |||
| AbstractCoordinator.HEARTBEAT_THREAD_PREFIX, | |||
| QuorumTestHarness.ZkClientEventThreadSuffix, | |||
| QuorumController.CONTROLLER_THREAD_SUFFIX, | |||
There was a problem hiding this comment.
It seems CONTROLLER_THREAD_SUFFIX can be removed from QuorumController
|
I will merge this PR after QA gets work. |
rreddy-22
pushed a commit
to rreddy-22/kafka-rreddy
that referenced
this pull request
May 24, 2024
…he#15984) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
TaiJuWu
pushed a commit
to TaiJuWu/kafka
that referenced
this pull request
Jun 8, 2024
…he#15984) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
TestUtils::verifyNoUnexpectedThreadsto check for all event queue threads instead of the incorrect QuorumController thread.Also updated
KafkaEventQueueTestto use try-with-resources to ensure threads get closed and to use LoggerContext with the current test name as the logPrefix for easier debugging.Committer Checklist (excluded from commit message)