Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-2442: Fixing transiently failing test #160

Closed
wants to merge 1 commit into from

Conversation

auradkar
Copy link
Contributor

Made the following changes:

  1. Made the quotas very small. (100 and 10 bytes/sec for producer and consumer respectively)
  2. For the producer, I'm asserting the throttle_time with a timed loop using waitUntilTrue
  3. For the consumer, I'm simply calling a timed poll in a loop until the server side throttle time metric returns true

@asfbot
Copy link

asfbot commented Aug 21, 2015

kafka-trunk-git-pr #192 SUCCESS
This pull request looks good

for (i <- 0 to count) {
val payload = i.toString.getBytes
numBytesProduced += payload.length
val payload = Array[Byte](100)
p.send(new ProducerRecord[Array[Byte], Array[Byte]](topic1, null, null, payload),
new ErrorLoggingCallback(topic1, null, null, true)).get()
Thread.sleep(1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remind me why this was needed and if it isn't we can remove it.

@enothereska
Copy link
Contributor

@auradkar, @jjkoshy : I had a look. One way to trigger the original test to fail consistently is to set the logging to TRACE in test.resources.log4j.properties. The new test passes, however the code is out of date with the recent trunk at this point. Could you resolve the conflicts if you get a chance?

@guozhangwang
Copy link
Contributor

@auradkar Could you address @jjkoshy comments and rebase?

@guozhangwang
Copy link
Contributor

@jjkoshy @lindong28 Is this JIRA still valid?

@asfbot
Copy link

asfbot commented Dec 21, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/321/
Test FAILed (JDK 8 and Scala 2.12).

@asfbot
Copy link

asfbot commented Dec 21, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/320/
Test FAILed (JDK 7 and Scala 2.10).

@asfbot
Copy link

asfbot commented Dec 21, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/322/
Test FAILed (JDK 8 and Scala 2.11).

@lindong28
Copy link
Member

@guozhangwang I was not aware of this ticket. Not sure if it is still an issue. I would prefer to just close this ticket if there is no ongoing complaint of this issue.

@guozhangwang
Copy link
Contributor

@lindong28 cool thanks.

@pono pono closed this Dec 26, 2016
jsancio pushed a commit to jsancio/kafka that referenced this pull request Aug 6, 2019
…pache#160)

In Phase 1 of RBAC, metadata server will be embedded in brokers. Add a metadata provider that will be loaded by our authorizer to load the metadata server plugin. The actual metadata server endpoints will be added by the implementation of this plugin.

Reviewers: Milo Simpson <milo@confluent.io>, Manikumar Reddy O <manikumar.reddy@gmail.com>
radai-rosenblatt pushed a commit to radai-rosenblatt/kafka that referenced this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
8 participants