Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR] Code Cleanup (Clients Module) #16049

Merged
merged 6 commits into from
Jun 4, 2024
Merged

[MINOR] Code Cleanup (Clients Module) #16049

merged 6 commits into from
Jun 4, 2024

Conversation

sjhajharia
Copy link
Contributor

What

Code Cleanup in Clients Module

Changes

Some common changes include

  • Replace the Arrays.asList() with Collections.singletonList() wherever possible
  • Cleaning up some if-else blocks
  • Replacing some instances of String.builder() with String operations

Thanks!

@sjhajharia sjhajharia mentioned this pull request May 24, 2024
Closed
@chia7712
Copy link
Contributor

@sjhajharia Could you please rebase code to include #16044? It fixes a lot of failed tests :)

@sjhajharia
Copy link
Contributor Author

Thanks for pointing out @chia7712
I rebased the PR!

@chia7712
Copy link
Contributor

I rebased the PR!

I guess other PRs will encounter same failed tests, so please rebase code for others too, thanks!

chia7712
chia7712 reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjhajharia thanks for updated PR

clients/src/main/java/org/apache/kafka/common/utils/Utils.java Outdated Show resolved Hide resolved
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java Outdated Show resolved Hide resolved
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java Outdated Show resolved Hide resolved
chia7712
chia7712 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 merged commit e4ff540 into apache:trunk Jun 4, 2024
1 check failed
@sjhajharia sjhajharia deleted the clients-code-cleanup branch June 4, 2024 11:11
TaiJuWu pushed a commit to TaiJuWu/kafka that referenced this pull request Jun 8, 2024
@sjhajharia @TaiJuWu
MINOR: Code Cleanup (Clients Module) (apache#16049)
7a0c6e2 
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
gongxuanzhang pushed a commit to gongxuanzhang/kafka that referenced this pull request Jun 12, 2024
@sjhajharia @gongxuanzhang
MINOR: Code Cleanup (Clients Module) (apache#16049)
cbd1ed9 
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sjhajharia @chia7712