MINOR: reduce the test suits of consumer group tools #16155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1a2st
changed the title
m1a2st
changed the title
chia7712
reviewed
May 31, 2024
| @@ -62,7 +63,7 @@ static List<ClusterConfig> forConsumerGroupCoordinator() { | |||
| serverProperties.put(NEW_GROUP_COORDINATOR_ENABLE_CONFIG, "true"); | |||
|
|
|||
| return Collections.singletonList(ClusterConfig.defaultBuilder() | |||
| .setTypes(Stream.of(KRAFT, CO_KRAFT).collect(Collectors.toSet())) | |||
There was a problem hiding this comment.
Could you please add comments for this change?
| @@ -75,6 +76,7 @@ static List<ClusterConfig> forClassicGroupCoordinator() { | |||
| serverProperties.put(NEW_GROUP_COORDINATOR_ENABLE_CONFIG, "false"); | |||
|
|
|||
| return Collections.singletonList(ClusterConfig.defaultBuilder() | |||
| .setTypes(Stream.of(ZK, KRAFT).collect(Collectors.toSet())) | |||
|
@m1a2st Could you please fix the conflicts? |
m1a2st
force-pushed
the
MINOR-Speed-up-ResetConsumerGroupOffsetTest
branch
from
fa6df27
to
e862f7f
Compare
|
Ok, I resolved the conflict |
chia7712
approved these changes
Jun 1, 2024
chia7712
changed the title
wernerdv
pushed a commit
to wernerdv/kafka
that referenced
this pull request
Jun 3, 2024
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
TaiJuWu
pushed a commit
to TaiJuWu/kafka
that referenced
this pull request
Jun 8, 2024
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
gongxuanzhang
pushed a commit
to gongxuanzhang/kafka
that referenced
this pull request
Jun 12, 2024
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
ConsumerGroupOffsetTesttest for a long time, so I think that we should reduce the test time.Committer Checklist (excluded from commit message)