Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Make new consumer default for Mirror Maker #1914

Closed
wants to merge 2 commits into from
Closed

MINOR: Make new consumer default for Mirror Maker #1914

wants to merge 2 commits into from

Conversation

hachikuji
Copy link
Contributor

No description provided.

@hachikuji
Copy link
Contributor Author

Review by @ijuma. This is a followup for KAFKA-3282.

ijuma
ijuma approved these changes Sep 27, 2016
View reviewed changes
Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM, just left a nitpick. Have you run the system tests to make sure they pass after your changes?

core/src/main/scala/kafka/tools/MirrorMaker.scala
if (useOldConsumer) {
if (options.has(useNewConsumerOpt)) {
error(s"The consumer configuration parameter `${ZKConfig.ZkConnectProp}` is not valid when using --new.consumer")
System.exit(1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: in scala sys.exit is slightly better than System.exit because it tells the type system that the method returns Nothing. In this case, it doesn't matter, but if you had an if/else for example, it would.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds sensible to me. I'll fix it.

@hachikuji
Copy link
Contributor Author

hachikuji commented Sep 27, 2016 •
edited

@ijuma Updated. I did run MM system tests here: http://testing.confluent.io/confluent-kafka-branch-builder-system-test-results/?prefix=2016-09-27--001.1474950996--hachikuji--mm-default-new-consumer--e58dceb/. I also ran replication tests to verify that removing the "--new-consumer" flag worked correctly in the console consumer service: http://testing.confluent.io/confluent-kafka-branch-builder-system-test-results/?prefix=2016-09-27--001.1474959619--hachikuji--mm-default-new-consumer--e58dceb/.

asfgit pushed a commit that referenced this pull request Sep 27, 2016
@hachikuji @ijuma
MINOR: Make new consumer default for Mirror Maker
aadda5a 
Author: Jason Gustafson <jason@confluent.io>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #1914 from hachikuji/mm-default-new-consumer

(cherry picked from commit 3db752a)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
@asfgit asfgit closed this in 3db752a Sep 27, 2016
@ijuma
Copy link
Contributor

ijuma commented Sep 27, 2016

Thanks for the PR, LGTM. Merged to trunk and 0.10.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijuma ijuma ijuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hachikuji @ijuma