KAFKA-4245: Don't swallow IOExceptions #1948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove swallowing of exceptions from BlockingChannel#connect. This commit also slightly reworks the handling of a BlockingChannel in KafkaServer to correctly handle the possibility of an IOException being thrown by BlockingChannel#connect().
gabrielreid
force-pushed
the
KAFKA-4245
branch
from
396a52b
to
df0d6a2
Compare
|
Looks like the Jenkins build plan failed due to a build env issue. FWIW, the full test suite runs cleanly for me. I've pushed the rebased branch in an effort to give Jenkins a kick to re-run the build. |
|
Closing this since the JIRA has been resolved. Pleas reopen if this was a mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove swallowing of exceptions from BlockingChannel#connect.
This commit also slightly reworks the handling of a
BlockingChannel in KafkaServer to correctly handle the possibility
of an IOException being thrown by BlockingChannel#connect().
Note that I'm totally new to Scala, so any advice on anything I might
be doing here that is unconventional or just plain wrong is
certainly welcome.