Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove failing ConnectDistributedTest.test_bad_connector_class #2131

Closed
wants to merge 1 commit into from
Closed

Remove failing ConnectDistributedTest.test_bad_connector_class #2131

wants to merge 1 commit into from

Conversation

shikhar
Copy link
Contributor

@shikhar shikhar commented Nov 15, 2016

Since #1911 was merged it is hard to externally test a connector transitioning to FAILED state due to an initialization failure, which is what this test was attempting to verify.

The unit test added in #1778 already exercises exception-handling around Connector instantiation.

Since #1911 was merged it is hard to externally test a connector transitioning to FAILED state due to an initialization failure, which is what this test was attempting to verify.

The unit test added in #1778 already exercises exception-handling around Connector instantiation.
@shikhar
Copy link
Contributor Author

shikhar commented Nov 15, 2016

@ewencp or @hachikuji for review

@hachikuji
Copy link
Contributor

LGTM

@asfgit asfgit closed this in a32962a Nov 15, 2016
@shikhar shikhar deleted the test_bad_connector_class branch November 15, 2016 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants