Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-4517: Remove deprecated shell script #2236

Closed
wants to merge 1 commit into from
Closed

KAFKA-4517: Remove deprecated shell script #2236

wants to merge 1 commit into from

Conversation

jeffwidman
Copy link
Contributor

Remove the kafka-consumer-offset-checker.sh script completely since it
was already deprecated in Kafka9

Currently it's quite confusing to new Kafka operators that this script
exists because it seems to do exactly what they want for checking
offsets, only to later realize they should instead use
kafka-consumer-groups.sh script

Remove the kafka-consumer-offset-checker.sh script completely since it
was already deprecated in Kafka9

Currently it's quite confusing to new Kafka operators that this script
exists because it seems to do exactly what they want for checking
offsets, only to later realize they should instead use
kafka-consumer-groups.sh script
@asfbot
Copy link

asfbot commented Dec 9, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/46/
Test PASSed (JDK 7 and Scala 2.10).

@asfbot
Copy link

asfbot commented Dec 9, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/47/
Test PASSed (JDK 8 and Scala 2.12).

@asfbot
Copy link

asfbot commented Dec 9, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/48/
Test FAILed (JDK 8 and Scala 2.11).

@guozhangwang
Copy link
Contributor

Thanks for the PR.

Usually we need to wait for a couple of major release cycles after deprecating a client / tool / etc before removing it, and also starting a DISCUSS email thread on kafka-dev before doing it. For example the old Scala consumer client. Would you like to start one discussion thread on the mailing list?

@jeffwidman
Copy link
Contributor Author

There was a somewhat similar discussion on the associated JIRA ticket, and I think someone marked this as relevant for the Kafka 11 release.

So I'm happy to start an email thread if needed, but I'm a little uncertain whether the non-email discussions regarding this should happen here on github or over on JIRA?

@guozhangwang
Copy link
Contributor

Yeah that is right. There were no hard-stone rules about how we should discuss about deprecations. Lately we are doing it more often in mailing list since it is most visible in the community. As for this specific deprecation, I think people would likely come to consensus quickly so shouldn't be much overhead.

@jeffwidman
Copy link
Contributor Author

Posted to the mailing list, no one piped up against, and @gwenshap expressed support for it.

@jeffwidman
Copy link
Contributor Author

Closing in favor of #3036

@jeffwidman jeffwidman closed this May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants