KAFKA-4526 - Disable throttling test until it can be fixed correctly. #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present, the test is fragile in the sense that the console consumer has to start and be initialized before the verifiable producer begins producing in the produce-consume-validate loop. If this doesn't happen, the consumer will miss messages at the head of the log and the test will fail. At present, the consumer is considered inited once it has a PID. This is a weak assumption. The plan is to poll appropriate metrics (like partition assignment), and use those as a proxy for consumer initialization. That work will be tracked in a separate ticket. For now, we will disable the tests so that we can get the builds healthy again.
|
LGTM, thanks. Please mention in the PR the new JIRA once it's filed. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
JIRA to track the proper fix is at: https://issues.apache.org/jira/browse/KAFKA-4558 |
|
Refer to this link for build results (access rights to CI server needed): |
soenkeliebau
pushed a commit
to soenkeliebau/kafka
that referenced
this pull request
Feb 7, 2017
At present, the test is fragile in the sense that the console consumer has to start and be initialized before the verifiable producer begins producing in the produce-consume-validate loop. If this doesn't happen, the consumer will miss messages at the head of the log and the test will fail. At present, the consumer is considered inited once it has a PID. This is a weak assumption. The plan is to poll appropriate metrics (like partition assignment), and use those as a proxy for consumer initialization. That work will be tracked in a separate ticket. For now, we will disable the tests so that we can get the builds healthy again. Author: Apurva Mehta <apurva.1618@gmail.com> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes apache#2278 from apurvam/KAFKA-4526-throttling-test-failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, the test is fragile in the sense that the console consumer
has to start and be initialized before the verifiable producer begins
producing in the produce-consume-validate loop.
If this doesn't happen, the consumer will miss messages at the head of
the log and the test will fail.
At present, the consumer is considered inited once it has a PID. This is
a weak assumption. The plan is to poll appropriate metrics (like
partition assignment), and use those as a proxy for consumer
initialization. That work will be tracked in a separate ticket. For now,
we will disable the tests so that we can get the builds healthy again.