KAFKA-4581: Fail early if multiple client login modules in sasl.jaas.config #2356
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
| JaasConfig jaasConfig = new JaasConfig(loginType, jaasConfigArgs.value()); | ||
| AppConfigurationEntry[] clientModules = jaasConfig.getAppConfigurationEntry(LoginType.CLIENT.contextName()); | ||
| if (clientModules != null && clientModules.length != 1) | ||
| throw new IllegalArgumentException("JAAS config property for clients must specify only one login module"); |
There was a problem hiding this comment.
Maybe worth stating the actual number as well.
There was a problem hiding this comment.
@ijuma Thank you for the review. I have updated the exception message.
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
…config Validate and fail client connection if multiple login modules are specified in sasl.jaas.config to avoid harder-to-debug authentication failures later on. Author: Rajini Sivaram <rajinisivaram@googlemail.com> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes apache#2356 from rajinisivaram/KAFKA-4581
Validate and fail client connection if multiple login modules are specified in sasl.jaas.config to avoid harder-to-debug authentication failures later on.