KAFKA-4467: Run tests on travis-ci using docker #2376
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
@raghavgautam Is this going to enable reports to GH PRs immediately based on the tests run? If it won't affect anyone negatively, then I think we're in good shape to just merge this.
On the other hand, if we can merge this now and work incrementally on getting the tests stable under TravisCI, then we could merge this immediately. Which is the case -- I think if we merge the .travis.yml file it'll start reporting failures on every PR; but if we can do this in a way that folks realize it's not a blocker, I think that could be ok. If it'll cause PRs to end up blocked unnecessarily, then I think we'd want to stabilize the tests first.
| - gradle wrapper | ||
|
|
||
| script: | ||
| - ./gradlew rat |
There was a problem hiding this comment.
Thanks for putting this check first, probably saves us a lot of time :)
tests/README.md
Outdated
|
|
||
| * Getting number of tests that were actually run | ||
| ``` | ||
| for id in $(curl -sSL https://api.travis-ci.org/builds/$BUILD_ID | jq '.matrix|map(.id)|.[]'); do curl -sSL "https://api.travis-ci.org/jobs/$id/log.txt?deansi=true" ; done | egrep 'RunnerClient: Loading test' | wc |
There was a problem hiding this comment.
Not really critical, but just linking to the JSON output format for the TravisCI API seems more useful (perhaps with one example of extracting relevant info with jq).
There was a problem hiding this comment.
@ewencp Would it be a problem if I use urls like:
https://travis-ci.org/raghavgautam/kafka/builds/191714520
This way I will be able to put working examples in the documentation.
Note: raghavgautam in the url
|
@ewencp This will not affect development of kafka in any way. The incoming pull requests & commits will not be affected. It will just help us to start working towards bringing up pass rates on travis-ci. Once, the pass rate of tests is good, we can discuss about integrating it with pull requests. |
|
@ewencp Please review. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
@ewencp Ping. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
+1 . @ewencp if you have any feedback that requires changes let us know. Otherwise I'll merge it in. |
There was a problem hiding this comment.
@raghavgautam @harshach A couple of questions. If the question around not installing jdk doesn't affect running outside of travis w/ docker, then go ahead and commit.
Only other thing I'd call out is that #2613 fixed some other issues, I'd try to make sure this patch isn't affected by those fixes.
| @@ -21,7 +21,7 @@ ENV MIRROR="http://apache.cs.utah.edu/" | |||
|
|
|||
| ADD ssh /root/.ssh | |||
| RUN chmod 600 /root/.ssh/id_rsa | |||
| RUN apt update && apt install -y unzip wget curl jq coreutils openssh-server net-tools vim openjdk-8-jdk python-pip python-dev libffi-dev libssl-dev | |||
| RUN apt update && apt install -y unzip wget curl jq coreutils openssh-server net-tools vim python-pip python-dev libffi-dev libssl-dev | |||
There was a problem hiding this comment.
Seems like removing the openjdk-8-jdk install will break things for anyone running on docker outside travis? Or I'm missing something?
Perhaps more helpfully, does it break if we still include the jdk so it will work for non-Travis cases?
There was a problem hiding this comment.
@ewencp Since we start with openjdk:8 image this is not necessary. (see line 16: FROM openjdk:8). And this change will not break anything.
There was a problem hiding this comment.
@ewencp Since we start with openjdk:8 image this is not necessary. (see line 16: FROM openjdk:8). And this change will not break anything.
| @@ -31,6 +31,309 @@ TC_PATHS="tests/kafkatest/tests/streams tests/kafkatest/tests/tools" bash tests/ | |||
| - The docker containers are named knode01, knode02 etc. | |||
| These nodes can't be used for any other purpose. | |||
|
|
|||
| Examining CI run | |||
| ---------------- | |||
| * Set BUILD_ID is travis ci's build id. E.g. build id is 169519874 for the following build | |||
There was a problem hiding this comment.
I'm guessing this is a chicken & egg situation, but we probably want to replace this eventually with an example ID that actually ran some tests :) Unless something went wrong when I ran the commands with this build ID? The docs here suggest I'll get output for tests, but all the test counts are zero for me w/ this ID.
|
And sorry for the very long delay on review :( |
|
I did look at #2613 when I was rebasing this pull request & resolving merge conflicts. |
|
LGTM |
@ijuma @ewencp @cmccabe @harshach Please review.
Here is a sample run:
https://travis-ci.org/raghavgautam/kafka/builds/191714520
In this run 214 tests were run and 144 tests passed.
I will open separate jiras for fixing failures.