KAFKA-2409; have KafkaConsumer.committed return null when there is no commit #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
kafka-trunk-git-pr #553 SUCCESS |
|
LGTM. |
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jan 21, 2022
…the RequestHandler threads and fetcher threads (apache#231)" (apache#243) This reverts commit a34a489. During certification, we found that this change is not safe. For example, suppose follower 0 is currently fetching data for partition tp0 from leader 1, and we are trying to switch the leadership to leader 2. In the previous implementation, tp0 goes through the following steps 1. tp0 is removed from the fetcher targeting leader 1, 2. retrieving the fetch offset based on the new leader's epoch. Say leader 2 returns a fetch offset of 100. 3. tp0 is added to a new fetcher thread with the fetch offset of 100. After the PR, the following race condition may happen 1. tp0 retrieves the fetch offset, e.g. 100, from leader 2 2. tp0 is concurrently sent for removal from the fetcher-with-leader-1 and add to the fetcher-with-leader-2 with a fetch offset of 100. Before the removal from fetcher-with-leader-1 is processed, more data may possibly be retrieved from leader 1 and appended to the log (e.g. making the log end offset to become 102). Then the fetch offset, i.e. 100, would not match the log end offset, i.e. 102.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.