KAFKA-4759: Add support for subnet masks in SimpleACLAuthorizer

[takebayashi]

No description provided.

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/1649/
Test PASSed (JDK 8 and Scala 2.11).

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1646/
Test PASSed (JDK 8 and Scala 2.12).

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/1646/
Test PASSed (JDK 7 and Scala 2.10).

[omkreddy]

looks like apache commons net does not support ipv6. Can we use any other third party library?
otherwise, +1 for the change.

[takebayashi]

I found commons-ip-math, which is maintained by RIPE NCC and licensed under the MIT license.
I will reimplement using it.

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/1669/
Test FAILed (JDK 8 and Scala 2.11).

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/1666/
Test FAILed (JDK 7 and Scala 2.10).

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1666/
Test PASSed (JDK 8 and Scala 2.12).

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/1830/
Test FAILed (JDK 8 and Scala 2.11).

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/1827/
Test FAILed (JDK 7 and Scala 2.10).

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1828/
Test FAILed (JDK 8 and Scala 2.12).

[takebayashi]

Can anyone review this change?
The test failure seems to be caused by other reasons.

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2135/
Test PASSed (JDK 8 and Scala 2.11).

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2132/
Test PASSed (JDK 7 and Scala 2.10).

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2133/
Test PASSed (JDK 8 and Scala 2.12).

[takebayashi]

I've rebased it on the trunk.
@ijuma can you review this? Thanks.

[mofakhar]

Since we do see Kafka 2.0.0 been pushed; Is there a plan/ETA when the support for subnet masks in SimpleACLAuthorizer can be implemented!!!?

Tested this with Kafka 1.0.0 as per below:
User:ANONYMOUS has Allow permission for operations: Write from hosts: 172.24.228.0/22 --> This is not working when defined
User:ANONYMOUS has Allow permission for operations: Write from hosts: 172.24.228.224 --> This working when its defined (with and without the line above)

Looking forward to hearing from you.
Cheers
Mo

[billygout]

+1. I need this. Can this be merged?

[aar6ncai]

+1

[saulius]

--allow-host is more or less useless without this. Cattle not pets!

[jhanssenfavaro]

Hi folks, any news about this ?
Would be very helpfull to have this CIDR annotation !!!

[rgo]

I've been working on it. I'm going to open a new PR and I'll link it to this one.

PR: #9387