Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Javadoc typo #2555

Closed
wants to merge 2 commits into from
Closed

MINOR: Javadoc typo #2555

wants to merge 2 commits into from

Conversation

astubbs
Copy link
Contributor

@astubbs astubbs commented Feb 16, 2017

No description provided.

@guozhangwang
KAFKA-2740: Add a KStream#peek(ForeachAction<K, V>) in DSL
5fcc458 
https://issues.apache.org/jira/browse/KAFKA-4720

Peek is a handy method to have to insert diagnostics that do not affect the stream itself, but some external state such as logging or metrics collection.

Author: Steven Schlansker <sschlansker@opentable.com>

Reviewers: Damian Guy, Matthias J. Sax, Eno Thereska, Guozhang Wang

Closes apache#2493 from stevenschlansker/kafka-4720-peek
@enothereska
Copy link
Contributor

LGTM, @astubbs could you prefix title with MINOR: Javadoc.... Thanks.

@asfbot
Copy link

asfbot commented Feb 16, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/1707/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot
Copy link

asfbot commented Feb 16, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/1704/
Test PASSed (JDK 7 and Scala 2.10).

@astubbs astubbs changed the title Javadoc typo MINOR: Javadoc typo Feb 16, 2017
@astubbs
Copy link
Contributor Author

astubbs commented Feb 16, 2017

How's that?

@asfbot
Copy link

asfbot commented Feb 16, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/1710/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot
Copy link

asfbot commented Feb 16, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/1707/
Test PASSed (JDK 7 and Scala 2.10).

@asfbot
Copy link

asfbot commented Feb 16, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1707/
Test PASSed (JDK 8 and Scala 2.12).

@enothereska
Copy link
Contributor

Oops. there is a mix up with the previous commit of peek. You have to rebase or merge your branch with trunk.

@astubbs
Copy link
Contributor Author

astubbs commented Oct 18, 2017

Moved here: https://github.com/apache/kafka/pull/4079/commits

@astubbs astubbs closed this Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@astubbs @enothereska @asfbot