KAFKA-2597: Add to .gitignore the Eclipse IDE directories #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kafka-trunk-git-pr #594 SUCCESS |
|
Should these two be folders, hence ".recommenders/"? |
|
@guozhangwang, the leading |
|
Thanks for the explanation, LGTM. |
jsancio
pushed a commit
to jsancio/kafka
that referenced
this pull request
Aug 6, 2019
omkreddy
pushed a commit
to omkreddy/kafka
that referenced
this pull request
Feb 15, 2021
Reviewers: Ismael Juma <ismael@juma.me.uk>
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Feb 4, 2022
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Feb 4, 2022
…he#261) TICKET = N/A LI_DESCRIPTION = The previous PR apache#259 added logic to retry failed tests for the `test` gradle task. This PR adds the retries for the `integrationTest` and `unitTest` tasks as well. This change is tested by adding a test that always fails, and verifying that the command below will retry the test for 3 times after the failure. export SCALA_VERSION=2.12 && ./gradlew -PmaxTestRetries=3 -PscalaVersion="$SCALA_VERSION" -PtestLoggingEvents=started,passed,skipped,failed --no-daemon core:integrationTest --rerun-tasks --tests '*.lucasTest' EXIT_CRITERIA = N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.metadataand.recommenderskeep IDE workspace state and should not be committed.