Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Follow up to KAFKA-2857 #2636

Closed
wants to merge 1 commit into from
Closed

MINOR: Follow up to KAFKA-2857 #2636

wants to merge 1 commit into from

Conversation

vahidhashemian
Copy link
Contributor

No description provided.

@vahidhashemian
Copy link
Contributor Author

@ijuma @hachikuji hopefully this will fix the broken unit tests.

@asfbot
Copy link

asfbot commented Mar 4, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/1991/
Test PASSed (JDK 7 and Scala 2.10).

hachikuji
hachikuji approved these changes Mar 4, 2017
View reviewed changes
Copy link
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this in a hurry. I'll let the remaining jenkins jobs finish before merging.

ijuma
ijuma approved these changes Mar 4, 2017
View reviewed changes
Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we should merge this since one of the jobs has succeeded. There's no reason to think the other ones will fail and trunk is currently failing.

@asfgit asfgit closed this in d2792e3 Mar 4, 2017
@asfbot
Copy link

asfbot commented Mar 4, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1992/
Test FAILed (JDK 8 and Scala 2.12).

@asfbot
Copy link

asfbot commented Mar 4, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/1994/
Test FAILed (JDK 8 and Scala 2.11).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijuma ijuma ijuma approved these changes

@hachikuji hachikuji hachikuji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@vahidhashemian @asfbot @ijuma @hachikuji