New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-4657: Improve test coverage of CompositeReadOnlyWindowStore #2672
Conversation
This commmit brings improved test coverage for window store fetch method and WindowStoreIterator
@guozhangwang @dguy please review when you have time |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @adyach. Appreciated. I just left one comment.
} | ||
|
||
@Test | ||
public void testWindowStoreIterator() throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you split this out into 2 tests please?. One for each method that is being tested. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dguy done
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
} | ||
|
||
@Test | ||
public void testWindowStoreIteratorHasNext() throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is preferable to have descriptive test names, i.e.,
emptyIteratorAlwaysReturnsFalse
emptyIteratorPeekNextKeyShouldThrowNoSuchElementException
etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed 90e6816
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adyach - appreciated. LGTM
LGTM and merged to trunk. |
This commmit brings improved test coverage for window store fetch method
and WindowStoreIterator