Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Make sure ProducerPerformance can bind with older client jar #2896

Closed
wants to merge 2 commits into from
Closed

Minor: Make sure ProducerPerformance can bind with older client jar #2896

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a0d3ea
Minor: Make sure ProducerPerformance can bind with older client jar
junrao Apr 22, 2017
a15efcf
address review comment
junrao Apr 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 14 additions & 7 deletions tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java
View file
Open in desktop
Expand Up @@ -129,17 +129,24 @@ record = new ProducerRecord<>(topicName, payload);
}
}

// Make sure all messages are sent before printing out the stats and the metrics
producer.flush();
if (!shouldPrintMetrics) {
producer.close();

/* print final results */
stats.printTotal();
/* print final results */
stats.printTotal();
} else {
// Make sure all messages are sent before printing out the stats and the metrics
// We need to do this in a different branch for now since tests/kafkatest/sanity_checks/test_performance_services.py
// expects the class to bind with old versions of the client jar that don't support flush().
producer.flush();

/* print final results */
stats.printTotal();

/* print out metrics */
if (shouldPrintMetrics) {
/* print out metrics */
ToolsUtils.printMetrics(producer.metrics());
producer.close();
}
producer.close();
} catch (ArgumentParserException e) {
if (args.length == 0) {
parser.printHelp();
Expand Down