Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-5119: Ensure global metrics are empty before running testMetricCollectionAfterShutdown #2915

Conversation

ijuma
Copy link
Contributor

@ijuma ijuma commented Apr 25, 2017

Depending on the test execution order, the global registry would
contain some metrics causing the test to fail.

@ijuma ijuma changed the title KAFKA-5119: Improve information in assert failure for testMetricCollectionAfterShutdown KAFKA-5119: Fix testMetricCollectionAfterShutdown Apr 26, 2017
@ijuma ijuma changed the title KAFKA-5119: Fix testMetricCollectionAfterShutdown KAFKA-5119: Ensure global metrics are empty before running testMetricCollectionAfterShutdown Apr 26, 2017
@ijuma
Copy link
Contributor Author

ijuma commented Apr 26, 2017

We were able to trigger this problem by running the test suite in a particular slave of Confluent Jenkins:

https://jenkins.confluent.io/job/kafka-branch-builder/112/

Running the test suite with the fix:

https://jenkins.confluent.io/job/kafka-branch-builder/115/

Copy link
Contributor

@ewencp ewencp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ijuma LGTM once we have the jenkins builds passing, thanks for tracking this down. And I assume the latest passing build on Confluent's jenkins is also verifying the fix no longer triggers the issue there.

@ijuma
Copy link
Contributor Author

ijuma commented Apr 26, 2017

@ewencp, that's right, the test passed in two Confluent Jenkins builds for the whole test suite.

@asfbot
Copy link

asfbot commented Apr 26, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3180/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot
Copy link

asfbot commented Apr 26, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3189/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot
Copy link

asfbot commented Apr 26, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3174/
Test PASSed (JDK 7 and Scala 2.10).

@asfbot
Copy link

asfbot commented Apr 26, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3175/
Test PASSed (JDK 8 and Scala 2.12).

@asfbot
Copy link

asfbot commented Apr 26, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3185/
Test PASSed (JDK 7 and Scala 2.10).

@asfbot
Copy link

asfbot commented Apr 27, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3184/
Test PASSed (JDK 8 and Scala 2.12).

@asfgit asfgit closed this in 909cf9b Apr 27, 2017
@ijuma ijuma deleted the socket-server-test-metric-collection-after-shutdown branch September 5, 2017 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants