New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-5119: Ensure global metrics are empty before running testMetricCollectionAfterShutdown #2915
KAFKA-5119: Ensure global metrics are empty before running testMetricCollectionAfterShutdown #2915
Conversation
We were able to trigger this problem by running the test suite in a particular slave of Confluent Jenkins: https://jenkins.confluent.io/job/kafka-branch-builder/112/ Running the test suite with the fix: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ijuma LGTM once we have the jenkins builds passing, thanks for tracking this down. And I assume the latest passing build on Confluent's jenkins is also verifying the fix no longer triggers the issue there.
@ewencp, that's right, the test passed in two Confluent Jenkins builds for the whole test suite. |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Depending on the test execution order, the global registry would
contain some metrics causing the test to fail.