KAFKA-5144 renamed and added comments to make it clear what's going on #2948
Conversation
…going on The descendingSubsequence is a misnomer. The linked list is actually arranged so that the lowest timestamp is first and larger timestamps are added to the end, therefore renamed to ascendingSubsequence. The minElem variable was also misnamed. It's actually the current maximum element as it's taken from the end of the list. Added comment to get() to make it clear it's returning the lowest timestamp.
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
@mihbor I manually changed your author signature from |
|
Great, thank you. Profile updated.
Cheers,
Michal
…On 03/05/17 21:45, Guozhang Wang wrote:
@mihbor <https://github.com/mihbor> I manually changed your author
signature from |mihbor ***@***.***>| to |Michal
Borowiecki ***@***.***>|. Let me know if you prefer the original
one, or you could change your local user / email profile accordingly
in the future.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2948 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AGCEaFDNGQkBjgzWQUBhUxL9dSLKwUWCks5r2OdagaJpZM4NMpsC>.
--
Signature
<http://www.openbet.com/> Michal Borowiecki
Senior Software Engineer L4
T: +44 208 742 1600
+44 203 249 8448
E: michal.borowiecki@openbet.com
W: www.openbet.com <http://www.openbet.com/>
OpenBet Ltd
Chiswick Park Building 9
566 Chiswick High Rd
London
W4 5XT
UK
<https://www.openbet.com/email_promo>
This message is confidential and intended only for the addressee. If you
have received this message in error, please immediately notify the
postmaster@openbet.com <mailto:postmaster@openbet.com> and delete it
from your system as well as any copies. The content of e-mails as well
as traffic data may be monitored by OpenBet for employment and security
purposes. To protect the environment please do not print this e-mail
unless necessary. OpenBet Ltd. Registered Office: Chiswick Park Building
9, 566 Chiswick High Road, London, W4 5XT, United Kingdom. A company
registered in England and Wales. Registered no. 3134634. VAT no.
GB927523612
|
The descendingSubsequence is a misnomer. The linked list is actually arranged so that the lowest timestamp is first and larger timestamps are added to the end, therefore renamed to ascendingSubsequence.
The minElem variable was also misnamed. It's actually the current maximum element as it's taken from the end of the list.
Added comment to get() to make it clear it's returning the lowest timestamp.