MINOR: Fix bug in waitUntilLeaderIsElectedOrChanged and simplify result type
#3031
Conversation
ijuma
force-pushed
the
fix-wait-until-leader-is-elected
branch
from
75a4410
to
d2a1d62
Compare
…sult type Also disable a couple of tests that were passing incorrectly until KAFKA-3096 is fixed. The bug was for the following case: `leader.isDefined && oldLeaderOpt.isEmpty && newLeaderOpt.isDefined && newLeaderOpt.get != leader.get` We would consider it a successful election even though we should not. I also changed the result type as we never return `None` (we throw an exception instead).
ijuma
force-pushed
the
fix-wait-until-leader-is-elected
branch
from
d2a1d62
to
792fc2a
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Review by @junrao |
|
@ijuma : Thanks for the patch. Good find and a great cleanup patch. LGTM. |
* Replace asynchronous mocked calls with synchronous mocks Signed-off-by: Greg Harris <gregh@confluent.io>
Also disable a couple of tests that were passing incorrectly until KAFKA-3096 is fixed.
The bug was for the following case:
leader.isDefined && oldLeaderOpt.isEmpty && newLeaderOpt.isDefined && newLeaderOpt.get != leader.getWe would consider it a successful election even though the new leader was not the expected leader.
I also changed the result type as we never return
None(we throw an exception instead).