KAFKA-4714: TimestampConverter transformation (KIP-66) #3065
Conversation
|
This is a WIP built on top of #2458, so you're seeing a larger diff than is ideal. The primary addition here is the |
|
@ewencp Trying to reclaim the LOC lead, eh? |
|
Refer to this link for build results (access rights to CI server needed): |
|
@hachikuji lol, removing the previous PR the diffstat is not very large. Just writing some code to keep myself sane :) |
|
Refer to this link for build results (access rights to CI server needed): |
| @@ -32,6 +32,7 @@ public static void requireSchema(Schema schema, String purpose) { | |||
| } | |||
| } | |||
|
|
|||
| @SuppressWarnings("unchecked") | |||
There was a problem hiding this comment.
Since you are touching this class, I noticed use of getCanonicalName. Do we want to change to getName here too? It doesn't really matter, it's only used for logging, but I mention it for consistency.
ewencp
force-pushed
the
kafka-3209-timestamp-converter
branch
from
9eafd31
to
1e80362
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
ewencp
force-pushed
the
kafka-3209-timestamp-converter
branch
from
1e80362
to
64b4ecb
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
ewencp
force-pushed
the
kafka-3209-timestamp-converter
branch
from
5ed1f20
to
93bad0a
Compare
|
@kkonstantine Updated, good catch. I've now grepped through the code to make sure we're not using @hachikuji If you happen to have time to review, we can probably squeeze this into 0.11.0.0 -- there's some sort of small feature provision to get things in post-feature-freeze. If not, we can always bump it to a future release, in which case I'll create yet another KIP-66 JIRA and relabel this. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
Author: Ewen Cheslack-Postava <me@ewencp.org> Reviewers: Konstantine Karantasis <konstantine@confluent.io>, Jason Gustafson <jason@confluent.io> Closes #3065 from ewencp/kafka-3209-timestamp-converter (cherry picked from commit 61bab2d) Signed-off-by: Jason Gustafson <jason@confluent.io>
No description provided.