KAFKA-5344: set message.timestamp.difference.max.ms back to Long.MaxValue #3163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
ijuma
approved these changes
May 30, 2017
There was a problem hiding this comment.
Thanks for the PR. These changes LGTM, but we also need to revert:
1f2ee5f#diff-71645c36b0dca57cf3e01e06e53f5f17L891
1f2ee5f#diff-71645c36b0dca57cf3e01e06e53f5f17R484
1f2ee5f#diff-8100f2416b657c1e1e4238dabf8a15e0R53
Since the changes are simple enough, I did them myself before merging to trunk and 0.11.0.
asfgit
pushed a commit
that referenced
this pull request
May 30, 2017
…alue Author: Jiangjie Qin <becket.qin@gmail.com> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes #3163 from becketqin/KAFKA-5344 (cherry picked from commit 6b03497) Signed-off-by: Ismael Juma <ismael@juma.me.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.