Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-5330: Use per-task converters in Connect #3196

Closed
wants to merge 2 commits into from

Conversation

tbcdns
Copy link
Contributor

@tbcdns tbcdns commented Jun 1, 2017

Instead of sharing the same converter instance within the worker, use a converter per task.

More details:

@asfbot
Copy link

asfbot commented Jun 1, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/4728/
Test FAILed (JDK 8 and Scala 2.12).

@asfbot
Copy link

asfbot commented Jun 1, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/4744/
Test FAILed (JDK 7 and Scala 2.11).

@tbcdns tbcdns changed the title KAFKA-5330: Use per-task converters KAFKA-5330: Use per-task converters in Connect Jun 1, 2017
@asfbot
Copy link

asfbot commented Jun 2, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/4766/
Test PASSed (JDK 7 and Scala 2.11).

@asfbot
Copy link

asfbot commented Jun 2, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/4750/
Test PASSed (JDK 8 and Scala 2.12).

@tbcdns
Copy link
Contributor Author

tbcdns commented Jun 2, 2017

@ewencp could you review this PR?

@tbcdns
Copy link
Contributor Author

tbcdns commented Aug 8, 2017

ping @ewencp :)

@asfgit
Copy link

asfgit commented Aug 8, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6639/
Test FAILed (JDK 7 and Scala 2.11).

@asfgit
Copy link

asfgit commented Aug 8, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6624/
Test PASSed (JDK 8 and Scala 2.12).

@tbcdns
Copy link
Contributor Author

tbcdns commented Aug 16, 2017

retest this please

@asfgit
Copy link

asfgit commented Aug 16, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6820/
Test PASSed (JDK 7 and Scala 2.11).

@asfgit
Copy link

asfgit commented Aug 16, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6806/
Test PASSed (JDK 8 and Scala 2.12).

@ewencp
Copy link
Contributor

ewencp commented Sep 22, 2017

LGTM, thanks!

@asfgit asfgit closed this in 7c988a3 Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants