KAFKA-2338: Warn on max.message.bytes change #322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
benstopford
commented
Oct 15, 2015
benstopford
commented
- Both TopicCommand and ConfigCommand warn if message.max.bytes increases
- Log failures on the broker if replication gets stuck due to an oversized message
- Added blocking call to warning.
benstopford
force-pushed
the
CPKAFKA-61
branch
2 times, most recently
from
9f22efd
to
924a252
Compare
| @@ -121,6 +122,13 @@ class ReplicaFetcherThread(name: String, | |||
| } | |||
| } | |||
|
|
|||
| def warnIfInvalid(messageSet: ByteBufferMessageSet): Unit = { | |||
There was a problem hiding this comment.
Would it be better to name this warnIfMessageOversized?
…ling replica fetches.
benstopford
force-pushed
the
CPKAFKA-61
branch
from
e5d9a20
to
7ffdd65
Compare
benstopford
force-pushed
the
CPKAFKA-61
branch
from
f4c18db
to
9066e35
Compare
|
@junrao your feedback has been incorporated |
|
Thanks for the patch. LGTM |
abbccdda
pushed a commit
to abbccdda/kafka
that referenced
this pull request
May 22, 2020
This patch adds a simple purgatory interface and integration with Kafka's `DelayedOperationPurgatory`. For the moment, we only support max wait time, which has been added to the `FetchQuorumRecords` request schema.
abbccdda
pushed a commit
to abbccdda/kafka
that referenced
this pull request
May 31, 2020
This patch adds a simple purgatory interface and integration with Kafka's `DelayedOperationPurgatory`. For the moment, we only support max wait time, which has been added to the `FetchQuorumRecords` request schema.
hachikuji
added a commit
to hachikuji/kafka
that referenced
this pull request
Aug 5, 2020
This patch adds a simple purgatory interface and integration with Kafka's `DelayedOperationPurgatory`. For the moment, we only support max wait time, which has been added to the `FetchQuorumRecords` request schema.
hachikuji
added a commit
to hachikuji/kafka
that referenced
this pull request
Aug 13, 2020
This patch adds a simple purgatory interface and integration with Kafka's `DelayedOperationPurgatory`. For the moment, we only support max wait time, which has been added to the `FetchQuorumRecords` request schema.
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
May 16, 2022
Can be squashed with Github workflow configs LI_DESCRIPTION = Reuses the test workflow in release to avoid duplication EXIT_CRITERIA = N/A
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jun 16, 2022
Can be squashed with Github workflow configs LI_DESCRIPTION = Reuses the test workflow in release to avoid duplication EXIT_CRITERIA = N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.