KAFKA-4948: Wait for offset commit in test to fix transient failure #3246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ijuma Can you take a look, please? Thank you... |
ijuma
reviewed
Jun 6, 2017
| // Wait for an offset commit before shutting down the group executor. | ||
| TestUtils.waitUntilTrue(() => { | ||
| val (_, assignments) = consumerGroupService.describeGroup() | ||
| !assignments.toSeq.flatMap(_.filter(_.group == group)).isEmpty |
There was a problem hiding this comment.
I think you can say something along the lines of assignments.exists(_.exists(_.group == group)) (I didn't try to compile it).
There was a problem hiding this comment.
@ijuma Thank you, updated. I will merge once the builds complete.
ijuma
approved these changes
Jun 6, 2017
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Test failure is unrelated, merging to trunk and 0.11.0. |
asfgit
pushed a commit
that referenced
this pull request
Jun 6, 2017
`DescribeConsumerGroupTest#testDescribeExistingGroupWithNoMembersWithNewConsumer` shuts down the consumer executor thread and then checks that the assignments returned by `describeGroup` contain the consume group with no members. But if the executor thread is shut down before any offsets are committed, the assignments returned by `describeGroup` doesn't contain the group at all. This PR waits for an offset commit by waiting for the group to appear in `describeGroup` assignments prior to shutting down the executor. Author: Rajini Sivaram <rajinisivaram@googlemail.com> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes #3246 from rajinisivaram/KAFKA-4948 (cherry picked from commit 3de6839) Signed-off-by: Rajini Sivaram <rajinisivaram@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DescribeConsumerGroupTest#testDescribeExistingGroupWithNoMembersWithNewConsumershuts down the consumer executor thread and then checks that the assignments returned bydescribeGroupcontain the consume group with no members. But if the executor thread is shut down before any offsets are committed, the assignments returned bydescribeGroupdoesn't contain the group at all. This PR waits for an offset commit by waiting for the group to appear indescribeGroupassignments prior to shutting down the executor.