KAFKA-5427: Transactional producer should allow FindCoordinator in error state #3297
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
| @@ -1279,16 +1345,43 @@ public void shouldNotSendAbortTxnRequestWhenOnlyAddOffsetsRequestFailed() throws | |||
|
|
|||
| TransactionalRequestResult abortResult = transactionManager.beginAbortingTransaction(); | |||
|
|
|||
| prepareAddOffsetsToTxnResponse(Errors.TOPIC_AUTHORIZATION_FAILED, consumerGroupId, pid, epoch); | |||
| prepareAddOffsetsToTxnResponse(Errors.GROUP_AUTHORIZATION_FAILED, consumerGroupId, pid, epoch); | |||
There was a problem hiding this comment.
The previous error is not expected for AddOffsets, which means it is a fatal error. The intent of the test case was apparently to trigger an abortable error. Note that I've added a test case for the fatal error case below.
|
|
||
| // we do not transition to ABORTABLE_ERROR since we were already aborting | ||
| assertTrue(transactionManager.isAborting()); | ||
| assertFalse(transactionManager.hasError()); |
There was a problem hiding this comment.
perhaps better to assert that transactionManager.hasAbortableError is false.
There was a problem hiding this comment.
The hasError check is strictly stronger. It covers both hasAbortableError and hasFatalError.
|
Merging to trunk and 0.11.0 |
…ror state Author: Jason Gustafson <jason@confluent.io> Reviewers: Ismael Juma <ismael@juma.me.uk>, Apurva Mehta <apurva@confluent.io>, Guozhang Wang <wangguoz@gmail.com> Closes #3297 from hachikuji/KAFKA-5427 (cherry picked from commit 43e935a) Signed-off-by: Jason Gustafson <jason@confluent.io>
No description provided.