Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-5508: Documentation for altering topics #3429

Closed
wants to merge 1 commit into from
Closed

KAFKA-5508: Documentation for altering topics #3429

wants to merge 1 commit into from

Conversation

huxihx
Copy link
Contributor

@huxihx huxihx commented Jun 26, 2017

Operations documentation should guide user to employ kafka-configs.sh to add/remove configs for a topic.

@huxihx
KAFKA-5508: Documentation for altering topics
ec66e8f 
Operations documentation should guide user to employ `kafka-configs.sh` to add/remove configs for a topic.
@huxihx
Copy link
Contributor Author

huxihx commented Jun 26, 2017

@ijuma A tiny doc update. Please review. Thanks.

@asfgit
Copy link

asfgit commented Jun 26, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5694/
Test PASSed (JDK 7 and Scala 2.11).

@asfgit
Copy link

asfgit commented Jun 26, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5680/
Test PASSed (JDK 8 and Scala 2.12).

@huxihx
Copy link
Contributor Author

huxihx commented Jun 27, 2017

@ijuma Hi, please take some time to review this tiny one. Thanks in advance.

@huxihx
Copy link
Contributor Author

huxihx commented Jun 29, 2017

@ijuma Could you take some time to review this PR? Thanks.

@ijuma
Copy link
Contributor

ijuma commented Jun 30, 2017

Thanks for the PR. A bit of a shame that we are telling users to use a more complicated command. Not sure what was the motivation to encourage people not to use the topic command to update topic configs.

@huxihx
Copy link
Contributor Author

huxihx commented Jun 30, 2017

@ijuma TopicCommand.alterTopic is marked as deprecated and I don't know why. Seems we do recommend user using kafka-configs.sh. Do you think it's okay to have this PR passed though?

@huxihx
Copy link
Contributor Author

huxihx commented Jul 3, 2017

@ijuma How do you think about the comments above?

@huxihx
Copy link
Contributor Author

huxihx commented Jul 6, 2017 •
edited

@dguy Could you please help review this tiny doc update? Thanks.

dguy
dguy approved these changes Jul 6, 2017
View reviewed changes
Copy link
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @huxihx, I've verified that the commands work. So, LGTM

asfgit pushed a commit that referenced this pull request Jul 6, 2017
@huxihx @dguy
KAFKA-5508; Documentation for altering topics
317de45 
Operations documentation should guide user to employ `kafka-configs.sh` to add/remove configs for a topic.

Author: huxihx <huxi_2b@hotmail.com>

Reviewers: Damian Guy <damian.guy@gmail.com>

Closes #3429 from huxihx/KAFKA-5508_Doc_for_altering_topics

(cherry picked from commit 6d20336)
Signed-off-by: Damian Guy <damian.guy@gmail.com>
@dguy
Copy link
Contributor

dguy commented Jul 6, 2017

Merged to trunk and cherry-picked to 0.11.0

@asfgit asfgit closed this in 6d20336 Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguy dguy dguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@huxihx @asfgit @ijuma @dguy