Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-3539: KafkaProducer.send() should not block #3478

Closed
wants to merge 1 commit into from

Conversation

evis
Copy link
Contributor

@evis evis commented Jul 3, 2017

Just wrapped current doSend() method invocation into another Future to get rid of blocking while calling KafkaProducer#send(). I know, that a lot of tests will be failed (including one I added), just want to know, is it appropriate to do such thing? If it is, I will try to fix tests.

@asfgit
Copy link

asfgit commented Jul 3, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5861/
Test FAILed (JDK 8 and Scala 2.12).

@asfgit
Copy link

asfgit commented Jul 3, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5876/
Test FAILed (JDK 7 and Scala 2.11).

@ijuma
Copy link
Contributor

ijuma commented Jul 7, 2017

Thanks for the PR. This change would potentially break a lot of existing users. It's worth starting a mailing list discussion to get input from a wider group. If people are in favour, then we'd need a KIP to be submitted.

@evis evis closed this Jul 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants