Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOTFIX: fix broken streams test #3493

Closed
wants to merge 1 commit into from
Closed

HOTFIX: fix broken streams test #3493

wants to merge 1 commit into from

Conversation

dguy
Copy link
Contributor

@dguy dguy commented Jul 6, 2017

No description provided.

@dguy
Copy link
Contributor Author

dguy commented Jul 6, 2017

@enothereska @ijuma

@enothereska enothereska mentioned this pull request Jul 6, 2017
Closed
@enothereska
Copy link
Contributor

Thanks @dguy let's see if the tests pass, LGTM otherwise.

@asfgit
Copy link

asfgit commented Jul 6, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5926/
Test PASSed (JDK 7 and Scala 2.11).

@asfgit
Copy link

asfgit commented Jul 6, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5911/
Test PASSed (JDK 8 and Scala 2.12).

ijuma
ijuma approved these changes Jul 6, 2017
View reviewed changes
Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm particularly familiar with this test, but it fixes a build breakage so let's merge it and if there are additional comments from others, we can address that separately.

@asfgit asfgit closed this in 0046a88 Jul 6, 2017
@dguy dguy deleted the hotfix-test-failure branch August 16, 2017 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijuma ijuma ijuma approved these changes

@enothereska enothereska enothereska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@dguy @enothereska @asfgit @ijuma