HOTFIX: correct sourceNodes for kstream.through() #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks. |
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Aug 29, 2022
…pache#374) TICKET = LI_DESCRIPTION = The request time metrics, such as LocalTime and TotalTime, are marked at the socket channel level upon request completion. When we introduce `LiCombinedControlRequest`, because now brokers don't receive those request individually (except for on IBP=2.4 or when a new Broker joins it expect a native full update), the processing time metrics of the composed control requests (`LeaderAndIsr`, `StopReplica`, `UpdateMetadata`) are effectively gone, and we only see the combined process time from `LiCombinedControlRequest`. This patch marks LocalTime and TotalTime for each decomposed sub-control requests when they're completed. The other time related metrics (e.g. ThrottleTime) are yet to be determined how to define, as in the context of "decompose", they doesn't seem valid. EXIT_CRITERIA = When LiCombinedControlRequest feature is ejected or replaced by upstream implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@guozhangwang